Skip to content

Honor early cancellation and improve fake executables #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manusoft merged 1 commit into from
Nov 4, 2026
Merged

Honor early cancellation and improve fake executables #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Ytdlp.NET/Ytdlp/Ytdlp.Execute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ public async Task<ProcessResult> ExecuteRawAsync(string arguments,
CancellationToken ct = default,
bool tuneProcess = true)
{
ct.ThrowIfCancellationRequested();

if (string.IsNullOrWhiteSpace(arguments))
throw new ArgumentException("Arguments cannot be null or empty.", nameof(arguments));

Expand Down
2 changes: 2 additions & 0 deletions src/Ytdlp.NET/Ytdlp/Ytdlp.Probe.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,8 @@ public async Task<List<SubtitleTrack>> GetSubtitlesAsync(string url, Cancellatio
{
try
{
ct.ThrowIfCancellationRequested();

var result = await CreateRunner().ExecuteAsync(
arguments,
onLineReceived: null,
Expand Down
2 changes: 1 addition & 1 deletion tests/Ytdlp.NET.Test/ArgumentTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public ArgumentTests()
{
try
{
File.WriteAllText(_fullFakePath, "");
File.WriteAllText(_fullFakePath, "fake yt-dlp executable");
}
catch (IOException)
{
Expand Down
2 changes: 1 addition & 1 deletion tests/Ytdlp.NET.Test/AudioFormatTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public AudioFormatTests()
{
try
{
File.WriteAllText(_fullFakePath, "");
File.WriteAllText(_fullFakePath, "fake yt-dlp executable");
}
catch (IOException)
{
Expand Down
2 changes: 1 addition & 1 deletion tests/Ytdlp.NET.Test/YtdlpAdobeAuthTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public YtdlpAdobeAuthTests()
{
try
{
File.WriteAllText(_fullFakePath, "");
File.WriteAllText(_fullFakePath, "fake yt-dlp executable");
}
catch (IOException)
{
Expand Down
2 changes: 1 addition & 1 deletion tests/Ytdlp.NET.Test/YtdlpAuthTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public YtdlpAuthTests()
{
try
{
File.WriteAllText(_fullFakePath, "");
File.WriteAllText(_fullFakePath, "fake yt-dlp executable");
}
catch (IOException)
{
Expand Down
2 changes: 1 addition & 1 deletion tests/Ytdlp.NET.Test/YtdlpBuilderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public YtdlpBuilderTests()
{
try
{
File.WriteAllText(_fullFakePath, "");
File.WriteAllText(_fullFakePath, "fake yt-dlp executable");
}
catch (IOException)
{
Expand Down
2 changes: 1 addition & 1 deletion tests/Ytdlp.NET.Test/YtdlpCancellationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public YtdlpCancellationTests()
{
try
{
File.WriteAllText(_fullFakePath, "");
File.WriteAllText(_fullFakePath, "fake yt-dlp executable");
}
catch (IOException)
{
Expand Down
2 changes: 1 addition & 1 deletion tests/Ytdlp.NET.Test/YtdlpEventTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public YtdlpEventTests()
{
try
{
File.WriteAllText(_fullFakePath, "");
File.WriteAllText(_fullFakePath, "fake yt-dlp executable");
}
catch (IOException)
{
Expand Down
Loading