Skip to content

fix: name verification artifacts and omit attribution claims - #32

Merged
malav2110 merged 1 commit into
malav2110:mainfrom
Aaqibhafeezkhan:fix/issue-2-verification-artifacts
Oct 22, 2026
Merged

malav2110 merged 1 commit into
malav2110:mainfrom
Aaqibhafeezkhan:fix/issue-2-verification-artifacts

Conversation

@Aaqibhafeezkhan

@Aaqibhafeezkhan Aaqibhafeezkhan commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Part of #2 by making verification limitations actionable and removing unrelated attribution speculation from the published sample.

  • Add guidance to identify public artifacts when an explanation says something could not be verified.
  • Add guidance against naming individual contributors or publishing unresolved attribution claims in sample pages.
  • Update the uPortal PR 2945 sample to link the relevant pull requests, branch and commit.
  • Remove the co-author attribution discussion, keeping the explanation focused on the code change.

Validation

  • Confirmed the updated sample names and links the relevant public artifacts.
  • Confirmed the attribution discussion is removed.
  • Confirmed the branch contains one commit and changes only the two scoped files.

@malav2110 malav2110 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking this on, @Aaqibhafeezkhan ! The links check out, and I have added a couple of comments inline.

For the sample, I'd rather have the page regenerated than edited by hand. #2 asks for that, so I'm fine taking it here this once. Once the rule fixes are in, could you regenerate the page from your branch and save it over the existing file? Before you push, please check that it names uPortal #2943, #2915, remove_fluid, and f2e3a459. It also shouldn't name anyone, link a fork, or discuss co-author credit.

Thank you again!

Comment thread skills/explain-diff-html/SKILL.md Outdated
Comment thread skills/explain-diff-html/SKILL.md Outdated
@Aaqibhafeezkhan
Aaqibhafeezkhan force-pushed the fix/issue-2-verification-artifacts branch from 84e0833 to 56a96c6 Compare October 20, 2026 09:33

@Aaqibhafeezkhan Aaqibhafeezkhan left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malav2110 Please re-review

@malav2110

Copy link
Copy Markdown
Owner

Thanks for the update, @Aaqibhafeezkhan! Both rule changes look good, so the SKILL.md side is ready.

Were you able to run the skill for the sample? Only section 7 changed, and the page is still dated 2026-09-01, so it looks hand-edited. If you can, please regenerate it from your branch and save it over the existing file. A fresh run is also the first real test of the two new rules, and the checks from my last comment still apply.

If you can't run the skill, that's fine too. Drop the sample change from this PR instead, and I'll regenerate the page after it merges.

Keep the approved skill guidance and defer the sample regeneration to the maintainer rather than presenting a hand-edited page as generated output.

Signed-off-by: Aaqibhafeezkhan <292322256+Aaqibhafeezkhan@users.noreply.github.com>
@Aaqibhafeezkhan
Aaqibhafeezkhan force-pushed the fix/issue-2-verification-artifacts branch from 56a96c6 to 19c83d6 Compare October 22, 2026 13:06

@Aaqibhafeezkhan Aaqibhafeezkhan left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malav2110

Thanks for the clarification. I couldn't run the skill end-to-end to regenerate the sample, so I followed your suggested fallback and removed the sample HTML change from this PR.

@malav2110

Copy link
Copy Markdown
Owner

Thanks, @Aaqibhafeezkhan! This is ready to merge.

I changed "Fixes #2" to "Part of #2" in the description, so the issue stays open until the sample is done.

@malav2110
malav2110 merged commit 2902a40 into malav2110:main Oct 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants