Repository navigation
fix: name verification artifacts and omit attribution claims - #32
Conversation
malav2110
left a comment
There was a problem hiding this comment.
Thank you for taking this on, @Aaqibhafeezkhan ! The links check out, and I have added a couple of comments inline.
For the sample, I'd rather have the page regenerated than edited by hand. #2 asks for that, so I'm fine taking it here this once. Once the rule fixes are in, could you regenerate the page from your branch and save it over the existing file? Before you push, please check that it names uPortal #2943, #2915, remove_fluid, and f2e3a459. It also shouldn't name anyone, link a fork, or discuss co-author credit.
Thank you again!
84e0833 to
56a96c6
Compare
Aaqibhafeezkhan
left a comment
There was a problem hiding this comment.
@malav2110 Please re-review
|
Thanks for the update, @Aaqibhafeezkhan! Both rule changes look good, so the SKILL.md side is ready. Were you able to run the skill for the sample? Only section 7 changed, and the page is still dated 2026-09-01, so it looks hand-edited. If you can, please regenerate it from your branch and save it over the existing file. A fresh run is also the first real test of the two new rules, and the checks from my last comment still apply. If you can't run the skill, that's fine too. Drop the sample change from this PR instead, and I'll regenerate the page after it merges. |
Keep the approved skill guidance and defer the sample regeneration to the maintainer rather than presenting a hand-edited page as generated output. Signed-off-by: Aaqibhafeezkhan <292322256+Aaqibhafeezkhan@users.noreply.github.com>
56a96c6 to
19c83d6
Compare
Aaqibhafeezkhan
left a comment
There was a problem hiding this comment.
Thanks for the clarification. I couldn't run the skill end-to-end to regenerate the sample, so I followed your suggested fallback and removed the sample HTML change from this PR.
|
Thanks, @Aaqibhafeezkhan! This is ready to merge. I changed "Fixes #2" to "Part of #2" in the description, so the issue stays open until the sample is done. |
Summary
Part of #2 by making verification limitations actionable and removing unrelated attribution speculation from the published sample.
Validation