Repository navigation
failed pages whose references are neither linked nor marked data-bare - #18
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2dcbf86 to
fbba6d9
Compare
malav2110
left a comment
There was a problem hiding this comment.
Thanks Andy! This closes the gap where unlinked references still passed CI. All 9 samples pass with it merged into main.
data-bare works for me as the marker, and the parser draft in #21 checks the same attribute. One small gap: the script only checks the attribute name. Either check for outside-repo, or drop "naming the reason" from validation.md.
@ChristianMurphy found three cases against this check in #21. I reproduced them, and the inline comments have tested fixes. I'd like lines 35, 40, and 45 fixed before merging. Line 36 is just a question.
|
@andyhorn, Christian's #29 replaces validate-output.sh and already fixes the spare-link and provenance cases, with a test page for each. So I'm dropping my asks on lines 40 and 45. Only the line 35 pattern is still needed. It keeps a |
…order are read Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T58NPz2J74Vkr1ABminq2L
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T58NPz2J74Vkr1ABminq2L
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T58NPz2J74Vkr1ABminq2L
|
Thanks @andyhorn ! I re-ran Christian's cases with GNU, BSD, and busybox tools. An unlinked filename wide label now fails, a |
Follows #17, #1, and #14. This is what lets the samples workflow catch a page whose references went unlinked.
The validator now fails a page when a
file:linereference is neither linked nor marked as deliberately bare.Why
validate-output.shprintedreferences=N linked=Mbut never compared the numbers. A page that dropped back to bare references, the defect the sample repair fixed, still exited 0, and so did CI.validation.mdasked the writer to compare the counts by hand. The rule allows two deliberate exceptions, but nothing on the page recorded which bare references were deliberate, so the script couldn't enforce it.Changes
data-bareattribute marks a deliberate exception, as in<code data-bare="outside-repo">main.py:8</code>. It doesn't affect rendering. SKILL.md,validation.md, and the template comment document it.references − markedare linked. Pages whose provenance line saysReferences are not linked(the unresolved-host case) are exempt.<code>span or.filenamelabel, andhost:portstrings with a common TLD, such asexample.com:8080, are no longer counted.main.py:8, the reader's own file and the only unlinked reference among the samples.Verification
localhost.example.com:8080is not counted.For the reviewer
data-bareis the marker you want, or whether you'd prefer another mechanism.🤖 Generated with Claude Code