Repository navigation
feat(awards): filter contracts and IDVs by commercial_item_acquisition_procedures (API 5.10.0) - #90
Merged
Conversation
…n_procedures (API 5.10.0) `list_contracts()` and `list_idvs()` take a new `commercial_item_acquisition_procedures` filter, matching the query param Tango API 5.10.0 adds to `/api/contracts/` and `/api/idvs/`. It filters by the FPDS commercial item acquisition procedures code `A`–`E` (case-insensitive, `E` being DoD Section 803 Commercial Solutions Opening), with `|` for OR. OTAs and OTIDVs do not take it, since the API does not offer it there. Re-vendors the API contract at 5.10.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
vdavez
marked this pull request as ready for review
October 16, 2026 18:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the
commercial_item_acquisition_proceduresfilter tolist_contracts()andlist_idvs(), matching the query param Tango API 5.10.0 adds toGET /api/contracts/andGET /api/idvs/.A(commercial products/services),B(products or services pursuant to FAR 12.102(f)),C(services pursuant to FAR 12.102(g)),D(commercial procedures not used),E(DoD Section 803 Commercial Solutions Opening).|, e.g.client.list_contracts(commercial_item_acquisition_procedures="A|E"); an unknown or multi-character code matches nothing.list_otas()/list_otidvs(): the API does not offer it there.Also re-vendors
contracts/filter_shape_contract.jsonat Tango API 5.10.0, which is what makes the conformance check require the new param on both methods.Changelog
commercial_item_acquisition_proceduresfilter onlist_contracts()andlist_idvs()(Tango API 5.10.0).contracts/filter_shape_contract.json(Tango API 5.10.0).Testing
uv run pytest: 650 passed, 1 skipped.tests/test_client.py(TestCommercialItemAcquisitionProceduresFilter): the value reaches the request verbatim on both methods, is omitted when unset, andlist_otas()/list_otidvs()reject it.uv run ruff format --check tango/,uv run ruff check tango/,uv run mypy tango/: clean.uv run python scripts/check_filter_shape_conformance.py: no errors (before the SDK change, it reported the param missing onlist_contractsandlist_idvs).uv run python scripts/check_shape_coverage.py: no new drift.Risks
Additive, keyword-only-in-practice optional parameter; no existing call changes behavior.
🤖 Generated with Claude Code