Repository navigation
feat: Tango API 5.11.0 parity with tango-python 1.18.0 - #26
Merged
Merged
Conversation
Re-vendors the API contract at Tango API 5.11.0 and regenerates the shape overlay. Contracts, IDVs, OTAs and OT IDVs accept the `obligations_by_fiscal_year(fiscal_year, obligated)` expand, with a new `FiscalYearObligation` type and schema. Opportunities and notices accept `attachments(extraction_status)`. `listContracts()` and `listIdvs()` type the `commercial_item_acquisition_procedures` filter (Tango API 5.10.0); OTAs and OT IDVs do not, because the API does not offer it there. `PaginatedResponse.countType` reports whether `count` is exact or approximate, read from each response's own `X-Results-CountType` header. Documents pipe-joined UEIs on `recipient_uei` / `uei`, and that Federal Register and eBuy alerts are alertable query types. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A non-2xx response with no dedicated error class threw `TangoAPIError("API request failed with status 403")`, so the API's explanation was only reachable through `responseData`. The message now ends with the reason the API sent (`detail`, or `error`/`message`/`detail` on a structured body, flat or nested under `detail`), matching tango-python 1.18.1. Non-JSON bodies keep the bare message.
Also moves `COUNT_TYPE_KEY` above the `parseRetryAfter` doc comment it had been inserted under, so the function gets its doc back.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
vdavez
force-pushed
the
feat/api-5.11.0-catchup
branch
from
October 19, 2026 19:51
47253e9 to
18b4b2c
Compare
vdavez
marked this pull request as ready for review
October 19, 2026 19:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Brings the Node SDK to parity with tango-python 1.18.1 against Tango API 5.11.0.
Stacked on #25 → #21 → #22 → #23. This branch contains those four PRs' commits, so until they merge its diff against
mainincludes them; the catch-up itself is the last commit. Merge it after #23.contracts/filter_shape_contract.jsonat Tango API 5.11.0 and regeneratessrc/shapes/generatedOverlay.ts.obligations_by_fiscal_year(fiscal_year, obligated)expand on contracts, IDVs, OTAs and OT IDVs: a newFiscalYearObligationmodel type and registered schema (fiscal_yearint,obligateddecimal), onCONTRACT_SCHEMA,IDV_SCHEMA,OTA_SCHEMAandOTIDV_SCHEMA, and on theContractandIDVmodel interfaces.attachments(extraction_status)on opportunities and notices, typed onOpportunityAttachment.commercial_item_acquisition_procedurestyped onListContractsOptionsandListIdvsOptions(so alsolistIdvAwards()/listIdvChildIdvs()), not on OTAs or OT IDVs (Tango API 5.10.0).PaginatedResponse.countType("exact"/"approximate"/null) from each response's ownX-Results-CountTypeheader. The HTTP client stamps the parsed list body under a symbol key, which survives the object spreads the list methods do and stays out of JSON, so concurrent calls never see each other's value.TangoAPIErrorfor a non-2xx status with no dedicated error class now ends its message with the server's reason (API request failed with status 403: <reason>), read fromdetail, orerror/message/detailon a structured body, flat or nested underdetail(parity with tango-python 1.18.1). The parsed body stays onresponseData; non-JSON bodies keep the bare message.recipient_uei/uei, the new expand and filter,countType, and the Federal Register and eBuy alert query types.Parity notes
nullnested list as[](existing behavior for every nested list), so the API'snullforobligations_by_fiscal_yearon IDVs arrives as[], where tango-python returnsNone. Changing that globally would change every nested list, so it is documented rather than special-cased.cursorbug fixed in tango-python 1.12.0 does not exist here; tests now pincursoronlistIdvs,listIdvAwards,listIdvChildIdvsandlistIdvTransactions.Testing
npm run lint,npm run typecheck,npm run build,npx vitest run(562 tests),npm run check-conformance,npm run check-shape-coverage, and the overlay regeneration check, all clean locally.tests/unit/utils.http.test.ts: a JSON body with a reason, a tier gate's reason flat and nested, a JSON body without one, and a non-JSON body.tests/unit/client.obligations-by-fiscal-year.test.tsandtests/unit/client.count-type.test.ts; additions toclient.shape-parity,client.typed-filtersandshapes.schema.parity.extraction_statuscases fail against the pre-5.11.0 overlay, so they test the re-vendor.🤖 Generated with Claude Code