Repository navigation
fix(conformance): persist file URLs across close and reopen - #67
Merged
Merged
Conversation
magnusp
force-pushed
the
fix/43-conformance-file-persistence
branch
from
October 21, 2026 22:34
d7e39fa to
5e02480
Compare
magnusp
force-pushed
the
fix/43-conformance-file-persistence
branch
from
October 21, 2026 22:38
5e02480 to
21a5da2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #43. Part of #54.
What changed
:memory:remain isolated per-connection namespaces.?journal_mode=WALdo not change the namespace. This limitation is documented.XerialFileUrlPersistenceTest: it closes every connection, reopens the same file URL, and reads the table. A second test writes through an absolute path and reads through the equivalent relative path.libsql-conformance/README.mddocumenting the URL mapping, persistence, and suite scope.Contract decision
I used the preferred retention design from Steering rather than the documented-ephemerality escape hatch. sqld keeps a namespace after its last connection closes, so retaining the path namespace until suite end is workable and gives the vendored tests SQLite-like close-and-reopen behavior. This is harness integrity, not an xerial parity decision; no xerial contract was changed.
Evidence
Run with
mise exec --:./mvnw -pl libsql-conformance -am -Dit.test=XerialFileUrlPersistenceTest verifySQLite error: no such table: persisted/SQLite error: no such table: mapped, proving the namespace was deleted on close and relative/absolute paths diverged../mvnw -pl libsql-conformance -am verify@DisabledInsertQueryTestcase)../mvnw -pl libsql-jdbc -am test./mvnw spotless:applyDeviations
None from the xerial contract. Harness limitation: URL pragmas remain ignored, now documented in the conformance README.