Repository navigation
refactor(jdbc): drop the unused StorageClass component from JdbcType - #255
Merged
Merged
Conversation
magnusp
force-pushed
the
refactor/i249-drop-jdbc-type-storage
branch
from
October 30, 2026 23:56
4d475c3 to
e8df1a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A
JdbcTypedescribes a declared type, and a declared type has no storage class. The record carried one anyway, and nothing read it: the runtime storage class belongs to aValue, and the live path isJdbcTypeMapping.storageClass(Value).What changed
storagecomponent fromJdbcTypeMapping.JdbcType.fallback,entry, andunsupported, and deleted theStorageClass.Xargument from every call site: six fallback constants and the registry rows (31entry, 5unsupported).StorageClassandstorageClass(Value), still used byLibsqlResultSetMetaDataand the fallback switch.Blast radius
None at runtime.
JdbcTypeis package-private and onlyJdbcTypeMappingconstructs it, so there is no public surface change and no test change. Type resolution, metadata, andgetObjectread the same fields.Verification
git grep -n '\.storage()' -- libsql-jdbcreturns nothing../mvnw clean verify: 1511 JDBC unit tests (1546 unit tests across the reactor), 192 itests, 271 conformance tests with 7 skipped, 0 failures../mvnw spotless:checkpasses.Fixes #249