Skip to content

refactor(jdbc): drop the unused StorageClass component from JdbcType - #255

Merged
magnusp merged 1 commit into
mainfrom
refactor/i249-drop-jdbc-type-storage
Oct 31, 2026
Merged

magnusp merged 1 commit into
mainfrom
refactor/i249-drop-jdbc-type-storage

Conversation

@magnusp

@magnusp magnusp commented Oct 30, 2026 •

Copy link
Copy Markdown
Owner

Why

A JdbcType describes a declared type, and a declared type has no storage class. The record carried one anyway, and nothing read it: the runtime storage class belongs to a Value, and the live path is JdbcTypeMapping.storageClass(Value).

What changed

  • Removed the storage component from JdbcTypeMapping.JdbcType.
  • Dropped the matching parameter from fallback, entry, and unsupported, and deleted the StorageClass.X argument from every call site: six fallback constants and the registry rows (31 entry, 5 unsupported).
  • Kept StorageClass and storageClass(Value), still used by LibsqlResultSetMetaData and the fallback switch.

Blast radius

None at runtime. JdbcType is package-private and only JdbcTypeMapping constructs it, so there is no public surface change and no test change. Type resolution, metadata, and getObject read the same fields.

Verification

  • git grep -n '\.storage()' -- libsql-jdbc returns nothing.
  • ./mvnw clean verify: 1511 JDBC unit tests (1546 unit tests across the reactor), 192 itests, 271 conformance tests with 7 skipped, 0 failures.
  • ./mvnw spotless:check passes.

Fixes #249

@magnusp magnusp changed the title refactor(jdbc): drop the unused StorageClass component from JdbcType (#249) refactor(jdbc): drop the unused StorageClass component from JdbcType Oct 30, 2026
@magnusp
magnusp force-pushed the refactor/i249-drop-jdbc-type-storage branch from 4d475c3 to e8df1a2 Compare October 30, 2026 23:56
@magnusp
magnusp merged commit aec1b8f into main Oct 31, 2026
6 checks passed
@magnusp
magnusp deleted the refactor/i249-drop-jdbc-type-storage branch October 31, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the unused StorageClass component from JdbcType

1 participant