Repository navigation
fix(jdbc): route label getters through their int overloads - #254
Merged
Merged
Conversation
magnusp
changed the title
magnusp
force-pushed
the
fix/i250-label-getter-checks
branch
2 times, most recently
from
October 30, 2026 23:42
6d55549 to
d6b446c
Compare
## Why `getArray(String)` and `getRef(String)` threw `SQLFeatureNotSupportedException` before any check. Every other label getter delegates through `findColumn`, so a closed result set, a declared N/A column, and an unknown label all reported the wrong error on these two methods. ## What changed - `LibsqlResultSet#getRef(String)` and `getArray(String)` now call `findColumn` and delegate to the int overload, matching `getBlob`, `getClob` and `getRowId`. - Added tests for the closed result set, the five N/A declared types, an unknown label, and an ordinary open column on both overloads. ## Blast radius Only error precedence changes on the two label overloads. An unknown label now raises `no such column`; a closed result set and a declared N/A column now raise the same message as the int overload. No supported read changes. ## Verification - `./mvnw -pl libsql-jdbc -Dtest=LibsqlResultSetTest test`: 54 tests, 0 failures. - `./mvnw clean verify`: 1555 unit tests, 192 itests, 271 conformance tests with 7 skipped, 0 failures. - `./mvnw spotless:check` passes. Fixes #250
magnusp
force-pushed
the
fix/i250-label-getter-checks
branch
from
October 30, 2026 23:48
d6b446c to
23e97a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
getArray(String)andgetRef(String)threwSQLFeatureNotSupportedExceptionbefore any check. Every other label getter delegates throughfindColumn, so a closed result set, a declared N/A column, and an unknown label all reported the wrong error on these two methods.What changed
LibsqlResultSet#getRef(String)andgetArray(String)now callfindColumnand delegate to the int overload, matchinggetBlob,getClob, andgetRowId.Blast radius
Only error precedence changes on the two label overloads. An unknown label now raises
no such column; a closed result set and a declared N/A column now raise the same message as the int overload. No supported read changes.getUnicodeStreamand theupdate*methods are untouched.Verification
./mvnw -pl libsql-jdbc -Dtest=LibsqlResultSetTest test: 54 tests, 0 failures../mvnw clean verify: 1520 JDBC unit tests (1555 unit tests across the reactor), 192 itests, 271 conformance tests with 7 skipped, 0 failures../mvnw spotless:checkpasses.Fixes #250