Repository navigation
refactor(jdbc): extract ForeignKeyMetadata - #232
Merged
Merged
Conversation
Move the imported and exported foreign key mappers, the key-name helpers, and the per-direction row ordering into a package-private ForeignKeyMetadata class. The two pragma SQL strings stay in MetadataSql.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts foreign key shaping from
LibsqlDatabaseMetaDatainto package-privateForeignKeyMetadata:PragmaRow) with per-direction factoriesfromImported/fromExportedJdbcRow)IMPORTED_ORDER,EXPORTED_ORDER)The two pragma SQL strings remain in
MetadataSql.Preservation
PK_FIRST_COLUMNfallbackKEY_SEQremains the pragma sequence plus oneDEFERRABILITYremainsimportedKeyInitiallyDeferrednameOrEmptyfor FK/PK names;getPrimaryKeyskeeps the primary key name nullprimaryKeyNamestill matches onlyCONSTRAINT <name> PRIMARY KEYforeignKeyNamereverse index rule unchangedpom.xmlchangeDiff
LibsqlDatabaseMetaData.java: 846 -> 641 lines.Probe
Changed
KEY_SEQto the raw pragma value ((int) pragma.seq()instead of(int) pragma.seq() + 1) in both directions:Reverted;
ForeignKeyMetadata.javahash matched the pre-probe value.Lanes
./mvnw -pl libsql-jdbc -am test./mvnw spotless:check./mvnw -pl libsql-conformance -am verifyFixes #209