Repository navigation
docs(conformance): make the query string part of the namespace identity - #186
Merged
Merged
Conversation
The URL mapping section said the query string was ignored, which contradicted XerialConformanceDriver.plan() and the harness tests. State that a different query string addresses a different namespace and that the option values are not applied to the server.
Owner
Author
|
Verdict: PASS Revision verified
Acceptance criteria (issue #182)
Behavior verified from the head checkout (commands exactly as requested)
Reviewer notes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The URL mapping section said the query string is ignored when deriving the namespace. That contradicts
XerialConformanceDriver.plan(), its class Javadoc, and two harness tests. A conformance author reading the README would treat two spellings of the same file as one database when they are isolated databases.What changed
Scope
Docs only. No code or test changes. The canonical statement work in #171 and #174 is untouched.
Blast Radius
Only the conformance README. No runtime behavior changes.
Verification
XerialHarnessTest#queryStringIsPartOfTheFileNamespace: Tests run: 1, Failures: 0, Errors: 0.?mode=roand?mode=rwderive different namespaces.XerialHarnessTest#fileNamespacesWithDifferentQueryStringsAreIsolated: Tests run: 1, Failures: 0, Errors: 0. The two variants cannot see each other's tables../mvnw spotless:checkexits 0.Closes #182.