Skip to content

feat(jdbc): implement savepoints and re-select the xerial SavepointTest - #184

Merged
magnusp merged 2 commits into
mainfrom
feat/173-savepoints
Oct 24, 2026
Merged

magnusp merged 2 commits into
mainfrom
feat/173-savepoints

Conversation

@magnusp

@magnusp magnusp commented Oct 23, 2026

Copy link
Copy Markdown
Owner

Why

JDBC savepoints were a hard unsupported no-op, and xerial's SavepointTest was rejected because of that gap. This is the same change as #179, re-issued on a branch based directly on main, because #179 was merged into a stacked base branch instead of main and so never reached main.

What changed

  • Implemented setSavepoint, setSavepoint with a name, rollback, and release over the transaction stream.
  • Flipped supportsSavepoints to true.
  • Vendored and selected the xerial SavepointTest, and added LibsqlSavepointTest with 15 tests.

Scope

  • Savepoint support and the conformance re-selection. No unrelated JDBC behavior changed.

Tradeoffs

  • None.

Blast Radius

  • Savepoint code path in the JDBC module, plus one new vendored conformance file. The upstream test opens two connections to one path, and the conformance driver maps a path to one sqld namespace, so it passes with no divergence.

Verification

Fixes #173

@magnusp
magnusp added this pull request to stack #185 October 23, 2026 23:47
@magnusp
magnusp merged commit efc6990 into main Oct 24, 2026
6 checks passed
@magnusp
magnusp deleted the feat/173-savepoints branch October 24, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement JDBC savepoints and re-select the xerial SavepointTest

1 participant