Skip to content

Share SqlTokenizer with the statement INSERT detection #155

Closed

Description

@magnusp

The tokenizer consolidation for SqlTableReference and LibsqlResultSetMetaData landed in #154. Two copies remain outside that scope. LibsqlStatement has its own skipQuoted, and LibsqlPreparedStatement has tokenize and skipQuoted, used by the INSERT, REPLACE, and WITH...INSERT generated-keys detection. They duplicate SqlTokenizer and can drift from it.

Expected: move both onto SqlTokenizer, keep the generated-keys semantics unchanged, and add behavior tests for INSERT, REPLACE, WITH...INSERT, comments, and quoted identifiers.

Activity

  1. magnusp commented on Oct 23, 2026

    @magnusp
    OwnerAuthor

    Landed in #165 (merge commit c34d08f). Both scanners now read SqlTokenizer, and the behavior tests cover INSERT, REPLACE, WITH...INSERT, comments, and quoted identifiers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions