Skip to content

Vendored PreparedStatementThreadTest passes when the race throws a runtime exception #118

Closed

Description

@magnusp

The #51 divergence in PreparedStatementThreadTest.testRace rethrows only AssertionError. Any other cause is swallowed, including NullPointerException, IndexOutOfBoundsException, and ConcurrentModificationException. These are the Java equivalent of the native crash the test exists to catch.

When queryThread.get() throws, closeThread.get() is never awaited.

This test guards #89, which serializes statement close and execute. A close and execute race that throws an NPE inside LibsqlResultSet still passes.

Expected:

  • Tolerate only an SQLException cause. Rethrow everything else.
  • Always await both futures.
  • Record the narrower divergence in the manifest.

Activity

  1. added
    bugSomething isn't working
    P2Normal priority: edge case, feature gap, or test/process improvement
    on Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Normal priority: edge case, feature gap, or test/process improvementbugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions