Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ configurations.all {
// multi-release overlay that this AGP's Jetifier can't parse ("Unsupported
// class file major version 68"). 1.15.x is the last line without that overlay
// and is still API-compatible with mockito's usage.
force 'net.bytebuddy:byte-buddy:1.15.11'
force 'net.bytebuddy:byte-buddy-agent:1.15.11'
force 'net.bytebuddy:byte-buddy:1.18.16'
force 'net.bytebuddy:byte-buddy-agent:1.18.16'
Comment on lines +145 to +146

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Android test builds will likely fail again with "Unsupported class file major version 68" because this bump undoes the pin added to stop that error. The comment at android/build.gradle:141-144 says byte-buddy 1.17.x and later ship a META-INF/versions/24 overlay. It says this AGP's Jetifier cannot parse that overlay, and that 1.15.x is the last line without it. 1.18.16 is past that line, and android/gradle.properties:26 sets android.enableJetifier=true. Fix: keep both force lines at 1.15.11 and ignore this dependency in dependabot. Or first remove the Jetifier dependency, by disabling it or upgrading AGP 8.1.4, and then update the comment.

Why this was flagged

android/gradle.properties:26 sets android.enableJetifier=true, and the buildscript uses AGP 8.1.4 (android/build.gradle:8). Because of that, Jetifier transforms every resolved artifact in the test classpaths, including byte-buddy that mockito-core/mockito-android 5.24.0 pull in (android/build.gradle:127-128). The new forces at android/build.gradle:145-146 resolve byte-buddy and byte-buddy-agent 1.18.16. That is within the 1.17.x+ range the comment at android/build.gradle:141-144 says ships a META-INF/versions/24 class (major 68) that this Jetifier cannot parse. So testDebugUnitTest and androidTest builds are expected to fail during the Jetifier transform with "Unsupported class file major version 68". On the base branch, the 1.15.11 pin avoids that failure. The PR changes only the version strings and does not change the Jetifier setting or the AGP version, so nothing else guards against the problem. The comment now also contradicts the code.

Verification: The diff changes android/build.gradle:145-146 from force 'net.bytebuddy:byte-buddy:1.15.11' / byte-buddy-agent:1.15.11 to 1.18.16. The conditions that made the pin necessary still hold. android/gradle.properties:26 still has android.enableJetifier=true. The buildscript still uses com.android.tools.build:gradle:8.1.4 (build.gradle:8).

Finding ID: f-34027951

}
}
Loading