Repository navigation
chore: bump net.bytebuddy:byte-buddy-agent from 1.15.11 to 1.18.16 in /android #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dependabot
wants to merge
1
commit into
main
Choose a base branch
from
dependabot/gradle/android/net.bytebuddy-byte-buddy-agent-1.18.16
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Android test builds will likely fail again with "Unsupported class file major version 68" because this bump undoes the pin added to stop that error. The comment at android/build.gradle:141-144 says byte-buddy 1.17.x and later ship a META-INF/versions/24 overlay. It says this AGP's Jetifier cannot parse that overlay, and that 1.15.x is the last line without it. 1.18.16 is past that line, and android/gradle.properties:26 sets android.enableJetifier=true. Fix: keep both force lines at 1.15.11 and ignore this dependency in dependabot. Or first remove the Jetifier dependency, by disabling it or upgrading AGP 8.1.4, and then update the comment.
Why this was flagged
android/gradle.properties:26 sets android.enableJetifier=true, and the buildscript uses AGP 8.1.4 (android/build.gradle:8). Because of that, Jetifier transforms every resolved artifact in the test classpaths, including byte-buddy that mockito-core/mockito-android 5.24.0 pull in (android/build.gradle:127-128). The new forces at android/build.gradle:145-146 resolve byte-buddy and byte-buddy-agent 1.18.16. That is within the 1.17.x+ range the comment at android/build.gradle:141-144 says ships a META-INF/versions/24 class (major 68) that this Jetifier cannot parse. So testDebugUnitTest and androidTest builds are expected to fail during the Jetifier transform with "Unsupported class file major version 68". On the base branch, the 1.15.11 pin avoids that failure. The PR changes only the version strings and does not change the Jetifier setting or the AGP version, so nothing else guards against the problem. The comment now also contradicts the code.
Verification: The diff changes android/build.gradle:145-146 from
force 'net.bytebuddy:byte-buddy:1.15.11'/byte-buddy-agent:1.15.11to1.18.16. The conditions that made the pin necessary still hold. android/gradle.properties:26 still hasandroid.enableJetifier=true. The buildscript still usescom.android.tools.build:gradle:8.1.4(build.gradle:8).Finding ID:
f-34027951