Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ configurations.all {
// multi-release overlay that this AGP's Jetifier can't parse ("Unsupported
// class file major version 68"). 1.15.x is the last line without that overlay
// and is still API-compatible with mockito's usage.
force 'net.bytebuddy:byte-buddy:1.15.11'
force 'net.bytebuddy:byte-buddy-agent:1.15.11'
force 'net.bytebuddy:byte-buddy:1.18.16'
force 'net.bytebuddy:byte-buddy-agent:1.18.16'
Comment on lines 142 to +146

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Android unit and instrumentation test builds will likely fail again with "Unsupported class file major version 68", which the 1.15.11 pin was there to prevent. The comment at lines 141-144 says byte-buddy 1.17.x and later ship a META-INF/versions/24 overlay. It says AGP 8.1.4's Jetifier cannot parse that overlay, and android.enableJetifier=true. 1.18.16 is newer than 1.17.7, so it has that overlay too. Fix: keep the force at 1.15.11, or ignore this bump in dependabot, until the build can run without Jetifier or on an AGP whose Jetifier handles Java 24+ class files. If 1.18.16 is kept, update the comment.

Why this was flagged

android/gradle.properties:26 sets android.enableJetifier=true, and android/build.gradle:8 uses AGP 8.1.4. Mockito 5.24.0 (lines 127-128) brings in byte-buddy and byte-buddy-agent, and configurations.all forces them for every configuration. The comment at lines 141-144 records why they were pinned: byte-buddy 1.17.7 has a META-INF/versions/24 multi-release overlay, and Jetifier fails on it with "Unsupported class file major version 68". 1.15.x is the last line without that overlay. This change forces 1.18.16, which is newer than 1.17.7, so the overlay comes back. That breaks testDebugUnitTest and androidTest dependency transforms, which pass on the base branch with 1.15.11. The comment was not updated, so it now contradicts the pinned version.

Verification: Trigger: any build that resolves a test classpath with Jetifier on. The diff changes android/build.gradle:145-146 from byte-buddy 1.15.11 to 1.18.16. The comment at lines 141-144 says 1.17.7 ships a META-INF/versions/24 overlay that this AGP's Jetifier can't parse. AGP 8.1.4 and Jetifier are still on, with no ignorelist entry for byte-buddy.

Finding ID: f-6e0dc16f

}
}
Loading