Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .claude/skills/sync-upstream/references/translation.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ A sync must keep these even when upstream's line differs.
- Orchestrate keeps its state in `~/.claude/projects/<slug>/pstack/orchestrate/<project-slug>/notes.md`, where upstream uses Cursor's Project tracker and store. Owners merge through `merge-gate`. In a `gh stack`, one owner is the single writer, because `gh stack sync` and `rebase` push every branch. The verifier runs on the other of `opus` and `sonnet` from the owner, since upstream's different-family rule has no all-Claude equivalent.
- Arena's cross-judge is the first `arena cross-judge pool` entry whose model differs from the parent's. Upstream picks by model family, and the port's pool is all Claude, so a family rule would always skip the judge. Opus and sonnet count as different judges.
- `.claude-plugin/plugin.json` carries no `version`, where upstream's `.cursor-plugin/plugin.json` does. Claude Code then versions a GitHub-hosted install by commit SHA, so every merge to `main` reaches `claude plugin update`. A version string that does not change blocks updates. The `plugin-version` rule in `scripts/check-port.ts` keeps it out. `claude plugin validate` warns about the missing version. That warning is expected.
- interrogate adds the blind-spot lenses (`references/blind-spots.md`, chosen in Frame and passed to every adversary; Exposure, Isolation, and Upgrade are mandatory for SDK and package changes), a Frame step that folds the touched directories' decision records into the intent, a PR number or URL as scope with each adversary's worktree on the PR head, and the someone-else's-PR flow (`references/review-comments.md`), all folded in from Lucas's retired pr-review-swarm skill. When a playbook runs it as the pre-PR gate, it hands the findings back instead of ending the turn. The gate's rules live in Opening a PR step 2, which applies every verified finding or treats it as a blocker. Upstream dropped interrogate from opening a PR. The port keeps it as the gate. It runs no tool-based analyzers: a CodeScene change-set step was tried and removed after an eval showed the reviewers already covered everything it found (PR #2).
- interrogate adds the blind-spot lenses (`references/blind-spots.md`, chosen in Frame and passed to every adversary; every lens whose trigger the change meets is mandatory), a Frame step that folds the touched directories' decision records into the intent, a PR number or URL as scope with each adversary's worktree on the PR head, and the someone-else's-PR flow (`references/review-comments.md`), all folded in from Lucas's retired pr-review-swarm skill. When a playbook runs it as the pre-PR gate, it hands the findings back instead of ending the turn. The gate's rules live in Opening a PR step 2, which applies every verified finding or treats it as a blocker. Upstream dropped interrogate from opening a PR. The port keeps it as the gate. It runs no tool-based analyzers: a CodeScene change-set step was tried and removed after an eval showed the reviewers already covered everything it found (PR #2).
- `skills/poteto-mode/scripts/merge-gate/` is port-only. It reuses watch-pr's readiness verdict without editing watch-pr, and adds the policy: allowed repos, human-only paths needing a human approval on the head, and head pinning with `--match-head-commit`. A PR in a GitHub native stack refuses `gh pr merge`, so the gate falls back to the merge-async REST endpoint with the same head SHA. `--stack` gates native stack positions 1 to the target as one unit: each open PR runs the same per-PR decision, with its expected base being the head of the open PR below it instead of trunk, and one merge-async call on the target, pinned to its head, lands the range atomically. merge-async pins only that head, so the gate re-reads every head and the stack just before the call and refuses a merged head it did not gate (`merged-ungated-head`). Upstream has no native stacks. Every playbook merges only through it, and a refusal is final: human-only changes are the user's to merge. The policy lives outside git, and editing it is on poteto-mode's always-pause list.
- Babysit step 9 runs the **correct** skill when a fixed review finding is the second of its class in the repo. Upstream has no link from review triage to correct.
- `principle-never-block-on-the-human` narrows its force-push example to "force-push to a shared branch", matching poteto-mode's Autonomy. Autopilot owners force-push their own branches with a lease on every rebase.
Expand Down
2 changes: 1 addition & 1 deletion skills/interrogate/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Adversaries try to break a change or a design. A finding survives only when a ru

The scope is what the user names. Given a PR number or URL, it is that PR: read it with `gh pr view <pr> --json title,body,baseRefName,headRefOid,files` and `gh pr diff <pr>`. Otherwise it is the branch diff from its merge base with the base branch, through the working tree. State the intent with the **in-your-own-words** skill (`${CLAUDE_SKILL_DIR}/../in-your-own-words/SKILL.md`), from the user's message, the commits, and the PR description. Ask the user when the intent is unclear.

Pick the blind-spot lenses from `${CLAUDE_SKILL_DIR}/references/blind-spots.md` that the change calls for, or none. Diff-scoped attacks cannot see what is missing, and the lenses cover that gap. A change to an SDK or another package that other code installs always takes Exposure, Isolation, and Upgrade. Its users run it in setups no test of the author's covers, so those failures surface first in their production, not in review.
Take every blind-spot lens in `${CLAUDE_SKILL_DIR}/references/blind-spots.md` whose "Use when" the change meets. A matching lens is never optional. Diff-scoped attacks cannot see what is missing, and the lenses cover that gap.

Read the decision records (ADRs, design docs) in the directories the change touches, and add the decisions that bear on it to the intent. A change that quietly reverses one breaks the intent.

Expand Down
6 changes: 3 additions & 3 deletions skills/interrogate/references/blind-spots.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Blind-spot Lenses

Diff-scoped review sees what a hunk gets wrong. It cannot see what is missing, because no line is wrong. These lenses cover that gap. The lead picks the ones the change calls for. Correctness review does not cover them on its own.
Diff-scoped review sees what a hunk gets wrong. It cannot see what is missing, because no line is wrong. These lenses cover that gap. Frame takes every lens whose "Use when" the change meets. Correctness review does not cover them on its own.

## Parity

Expand All @@ -16,12 +16,12 @@ Use when options or features can combine, or a resource has a create, use, dispo

## Exposure

Use when the change writes anything that leaves the process: telemetry, logs, error reports, responses, files. List every value the change sends to such a destination and trace each one back to its source. Put a canary secret in each untrusted input, including metadata, headers, identifiers, URLs, and error text, and run every path that writes to the destination, not only the new one. Report every place the canary arrives unredacted, and every new field that skips the redaction the existing fields pass through.
Use when the change adds or reshapes a value that leaves the process: telemetry, logs, error reports, responses, files. Trace each such value back to its source. Put a canary secret in each untrusted input that feeds it, including metadata, headers, identifiers, URLs, and error text, and run every path the change adds or alters that writes it out. Report every place the canary arrives unredacted, and every new value that skips the redaction its neighbors in the same payload pass through.

## Isolation

Use when the change touches state that outlives one request or call: instance fields, module-level caches, maps keyed by name, anything cleared and rebuilt. Interleave two callers with different identities and inputs, once on one shared instance and once on a fresh instance per request. Report any value from one caller that shows up in the other's output, any result that depends on which instance served an earlier request, and any window where a reader sees state half rebuilt.

## Upgrade

Use when the change ships in a package other code installs. Act as a user who upgrades and changes no code. Run their setup with default options before and after the change, and diff everything they can observe: payloads, schemas, return values and their identity, the arguments that reach their own handlers, thrown errors. Hold the change to every promise the docs make, such as "never throws" or "leaves your input unchanged". Report each difference the changelog does not name, and each one that breaks the promise of the version bump it ships under.
Use when the change reaches consumers outside this repo: a package other code installs, a public API, a CLI, or a tool, event, or file schema that others read. Act as a consumer who upgrades or keeps calling and changes nothing on their side. Run their setup with default options before and after the change, and diff everything they can observe: payloads, schemas, return values and their identity, the arguments that reach their own handlers, thrown errors. Hold the change to every promise the docs make, such as "never throws" or "leaves your input unchanged". Report each difference the changelog does not name, and each one that breaks the compatibility promise it ships under, such as its version bump.
Loading