Skip to content

Fix secret value comparisons on Mainline #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pedrozc90 merged 13 commits into from
Oct 23, 2026
Merged

Fix secret value comparisons on Mainline #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f7ef99b
rebuild plan
pedrozc90 Oct 21, 2026
fa285d5
fix cooldown state and secret timer text, record phase 0 results
pedrozc90 Oct 22, 2026
fc357c8
split aura implementation per client family, record phase 1 results
pedrozc90 Oct 22, 2026
733762d
use aura containers for player auras and buffs on mainline, record ph…
pedrozc90 Oct 22, 2026
35ef972
record experiments 4 and 5 results, add /filger exp4 and exp5
pedrozc90 Oct 22, 2026
a27196e
test private auras
pedrozc90 Oct 23, 2026
2cb701c
use aura containers for target and focus frames on mainline
pedrozc90 Oct 23, 2026
7357393
use aura container and private aura anchors for boss debuffs on mainline
pedrozc90 Oct 23, 2026
fd0d8ac
use aura container for player debuffs on mainline
pedrozc90 Oct 23, 2026
8e4d538
remove unused aura event path from mainline
pedrozc90 Oct 23, 2026
015eea8
remove classic tooltip index branch, record experiments 7 and 8
pedrozc90 Oct 23, 2026
11d184a
add /filger exp10 for item cooldown refresh events
pedrozc90 Oct 23, 2026
93d34fa
dedupe cooldown buttons by active override spell
pedrozc90 Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
523 changes: 117 additions & 406 deletions Filger.lua
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions Filger.toc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,5 @@ data\shared\blacklist.lua
data\shared\cooldowns.lua
core\init.xml
config.lua
core\[Family]\auras.lua
Filger.lua
140 changes: 7 additions & 133 deletions config.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,7 @@ local Filger = ns.Filger

ns.data.Finalize()

local class = Filger.class
local cooldowns = Filger.cooldowns or {}
local spells = Filger.spells or {}
local all = Filger.all or {}

------------------------------------------------------------
-- Config
Expand All @@ -28,10 +25,6 @@ local all = Filger.all or {}
* hidePlayer --
]]

local size = 35
local spacing = 5
local xOffset, yOffset = 239, 39

Filger.config = {
["general"] = {
["backdrop"] = {
Expand All @@ -44,133 +37,14 @@ Filger.config = {
["well_fed"] = false, -- enabled filter to hide well fed buff (too many spells with this name)
["gametooltip"] = true, -- enabled tooltips
},
-- shared by the aura frames in core/<Family>/auras.lua
["layout"] = {
size = 35,
spacing = 5,
xOffset = 239,
yOffset = 39
},
["frames"] = {
-- LEFT
["PLAYER_DEBUFFS"] = {
enabled = true,
unit = "player",
filter = "HARMFUL",
anchor = { "RIGHT", UIParent, "CENTER", -xOffset, yOffset },
limit = 8,
size = size,
spacing = spacing,
initialAnchor = "BOTTOMRIGHT",
["growth-x"] = "LEFT",
["growth-y"] = "DOWN",
spells = {
[124275] = { enabled = true, priority = 3 }, -- Light Stagger
[124274] = { enabled = true, priority = 3 }, -- Moderate Stagger
[124273] = { enabled = true, priority = 3 } -- Heavy Stagger
}
},
["PLAYER_AURAS"] = {
enabled = true,
unit = "player",
filter = "PLAYER|HELPFUL",
anchor = { "RIGHT", UIParent, "CENTER", -xOffset, 0 },
limit = 8,
size = size,
spacing = spacing,
initialAnchor = "BOTTOMRIGHT",
["growth-x"] = "LEFT",
["growth-y"] = "DOWN",
spells = Mixin(spells[class] or {}, spells["ALL"] or {})
},
["PLAYER_BUFFS"] = {
enabled = true,
unit = "player",
filter = "HELPFUL",
caster = "all",
hidePlayer = true,
anchor = { "RIGHT", UIParent, "CENTER", -xOffset, -yOffset },
limit = 8,
size = size,
spacing = spacing,
initialAnchor = "BOTTOMRIGHT",
["growth-x"] = "LEFT",
["growth-y"] = "DOWN",
FilterAura = function(element, unit, data)
return data.enabled and not data.isPlayerAura
end
},
["TARGET_DEBUFFS"] = {
enabled = true,
unit = "target",
filter = "HARMFUL",
anchor = { "LEFT", UIParent, "CENTER", xOffset, yOffset },
limit = 8,
size = size,
spacing = spacing,
initialAnchor = "BOTTOMLEFT",
["growth-x"] = "RIGHT",
["growth-y"] = "DOWN",
spells = all,
FilterAura = function(element, unit, data)
if UnitCanAttack(unit, "player") then
return data.enabled and data.isPlayerAura
end
return data.enabled and not data.isPlayerAura
end,
SortAuras = function(a, b)
if (a.priority ~= b.priority) then
return a.priority < b.priority
end

if (a.expirationTime ~= b.expirationTime) then
return a.expirationTime < b.expirationTime
end

if (a.isPlayerAura ~= b.isPlayerAura) then
return a.isPlayerAura
end

return a.auraInstanceID < b.auraInstanceID
end
},
["TARGET_AURAS"] = {
enabled = true,
unit = "target",
filter = "HELPFUL",
anchor = { "LEFT", UIParent, "CENTER", xOffset, 0 },
limit = 8,
size = size,
spacing = spacing,
initialAnchor = "BOTTOMLEFT",
["growth-x"] = "RIGHT",
["growth-y"] = "DOWN",
spells = all
},
["FOCUS_DEBUFFS"] = {
enabled = true,
unit = "focus",
filter = "HARMFUL",
anchor = { "LEFT", UIParent, "CENTER", xOffset, -yOffset },
limit = 8,
size = size,
spacing = spacing,
initialAnchor = "BOTTOMLEFT",
["growth-x"] = "RIGHT",
["growth-y"] = "DOWN",
desaturated = false,
FilterAura = function(element, unit, data)
return data.enabled and data.isBossAura or (data.sourceUnit == nil) or not data.isFromPlayerOrPlayerPet
end
},
["BOSS_DEBUFFS"] = {
enabled = false,
unit = "player",
filter = "HARMFUL",
anchor = { "CENTER", UIParent, "CENTER", 0, 160 },
limit = 1,
size = math.floor(1.5 * size),
spacing = spacing,
initialAnchor = "BOTTOMLEFT",
["growth-x"] = "RIGHT",
["growth-y"] = "DOWN",
FilterAura = function(element, unit, data)
return data.enabled and data.isBossAura or (data.sourceUnit == nil)
end
},
["PLAYER_COOLDOWNS"] = {
enabled = true,
unit = "player",
Expand Down
Loading
Loading