Skip to content

fix: reject unsupported TLS ALPN in HTTP codecs - #31

Merged
localzet merged 2 commits into
mainfrom
fix/reject-unsupported-http-alpn
Nov 21, 2026
Merged

localzet merged 2 commits into
mainfrom
fix/reject-unsupported-http-alpn

Conversation

@localzet

Copy link
Copy Markdown
Owner

What changed

  • Close built-in HTTP and WebSocket connections when TLS negotiates an ALPN other than http/1.1.
  • Add mTLS integration coverage for h2 negotiation on HTTPS and WSS listeners; verify EOF without timeout and no HTTP/1 response.
  • Document the protocol boundary in English and Russian READMEs.

This does not add HTTP/2 support. It prevents the existing HTTP/1 codecs from misinterpreting another negotiated protocol.

Verification

  • composer run lint
  • composer run analyze
  • composer run test:all
  • bash tests/mtls_integration.sh

localzet and others added 2 commits November 21, 2026 19:12
This commit fixes the style issues introduced in 13c9bd4 according to the output
from PHP CS Fixer.

Details: #31
@deepsource-io

deepsource-io Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

DeepSource Code Review

We reviewed changes in e1974cb...3c3b0ff on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Nov 21, 2026 4:14p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@localzet
localzet merged commit 3b88805 into main Nov 21, 2026
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant