Repository navigation
chore: hickey gates every commit - #62
Open
lloyal-research wants to merge 3 commits into
Open
lloyal-research wants to merge 3 commits into
lloyal-research wants to merge 3 commits into
Conversation
Every commit is judged by hickey, the acceptance gate, before it exists, and carries the verdict as trailers; a pull request to main is checked in seconds by reading them, with no native build. The judge reads the principles hickey ships. lefthook runs the installed binary from the three hooks and is installed by npm install through the prepare script, which before pack and publish writes the hooks and nothing else. CONTRIBUTING states the contract: Claude Code among the prerequisites, judged commits and the gate check in the pull-request flow, the release commit judged like any other. Gate: gets in. The acceptance gate gets one owner, hickey, wired through the file named for hooks and checked by a workflow named for its one concern, with nothing duplicated and no file made a bag; fix the Node 22 line that the new prerequisite contradicts and tell contributors to rebase, since merge commits carry no trailer and the gate will refuse them. Gate-Refused-Before: 1 refusal on the way to this shape. Last: The gate itself is placed and composed correctly, but it changes what a contributor needs to commit here while leaving CONTRIBUTING.md stating the old contract, so update its Prerequisites and Pull Requests sections in this commit, use the same install line as the other workflows, and fix the --no-verify claim in the lefthook.yml comment.
The manifest already requires it, and the gate does too. Gate: gets in. The guide now matches the engines field and CI, so a contributor no longer installs a Node version npm will reject, though docs/distribution.md line 72 still says 22+ and should be corrected to 24 as well.
There was a problem hiding this comment.
🟡 Changes recommended
The gate includes GitHub’s unjudged synthetic merge commit, causing otherwise compliant PRs to fail.
1 open issue
What changed in this PR
Adds hickey commit judging to the repository’s contribution workflow and a trailer-based PR gate without a native build.
Changes:
- Installs commit hooks and configures required judging.
- Adds a PR workflow to check commit trailers.
- Updates contributor prerequisites and release guidance.
| File | Description |
|---|---|
| package.json | Adds hook installation and development dependencies. |
| package-lock.json | Locks new tooling and updates native package entries. |
| lefthook.yml | Runs judging, trailer recording, and post-commit hooks. |
| hickey.config.json | Requires judging for framework code. |
| CONTRIBUTING.md | Documents Node 24 and the judged-commit workflow. |
| .github/workflows/gate.yml | Adds PR commit-trailer validation. |
Review effort: Balanced
| node-version: 24 | ||
| - run: npm install --ignore-scripts | ||
| - name: Every commit carries the gate's record | ||
| run: npx hickey carried "origin/${{ github.base_ref }}...HEAD" |
The pre-commit hook runs hickey committing, which takes a verdict recorded while working in place of judging again; hickey staged now means judge. The record's second trailer is Refused-Before, and every verdict recorded under 0.1.x reads as not judged after the upgrade. Gate: gets in. The whole makes more sense with the change: the judge is upgraded through its one wiring point and the three hooks now share a lifecycle-moment vocabulary, with no duplicated decision left behind.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every commit to this repository is judged by hickey, the acceptance gate, before it exists, and carries the verdict as git trailers. A pull request to
mainis checked in seconds by reading them: thegateworkflow runshickey carriedover the range and refuses when any commit carries none. No native build is involved.lefthook.ymlruns the installedhickeybinary frompre-commit,prepare-commit-msgandpost-commit;npm installinstalls the hooks through thepreparescript, which before pack and publish writes the hooks and nothing else.hickey.config.jsondeclares the repository as framework code that requires the judge. It names no principles document of its own: the judge reads the principles hickey ships..github/workflows/gate.ymlis the pull-request check, in the repository's established install form.CONTRIBUTING.mdstates the contract: Claude Code among the prerequisites, judged commits and the gate check in the pull-request flow, the release commit judged like any other, Node 24.Every commit on this branch went through the hooks it installs. The first attempt was refused by the judge for leaving the contributing guide on the old contract, and the refusal is recorded on the commit that got in.