Repository navigation
Address data streams e2e test failure - #749
Merged
Merged
Conversation
|
1egoman
force-pushed
the
fix-data-streams-e2e
branch
from
October 19, 2026 19:23
903442a to
e9dff31
Compare
CI has seen a clean eos land before disconnect completes, ending the read with the chunks buffered so far. Accept that outcome again while the native cause is investigated. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
xianshijing-lk
approved these changes
Oct 19, 2026
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
cloudwebrtc
added a commit
that referenced
this pull request
Oct 21, 2026
* chore: bump rtc-ffi-bindings to 0.12.83. * update. * Address data streams e2e test failure (#749) * fix: address data streams e2e test failure * test: tolerate a clean end-of-stream when the room disconnects CI has seen a clean eos land before disconnect completes, ending the read with the chunks buffered so far. Accept that outcome again while the native cause is investigated. * bump to 0.13.0. * bump to 0.13.1. * add .changset. --------- Co-authored-by: Ryan Gaus <ryan.gaus@livekit.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to livekit/rust-sdks#1510 being merged, an e2e test has started breaking:
Previously, if a data stream was in progress and a room disconnected, the e2e tests would assert that the data stream would silently just end and return the buffered text. As of livekit/rust-sdks#1510, this behavior changes to now reject with an explicit
Error: stream closed abnormally: Data stream connection closederror in this case. So, update the e2e tests to also check this.Important
UPDATE: After e9dff31, the e2e tests still failed. I had a LLM investigate it and it seems like the old failure mode that this rust sdks fix was aiming to prevent still seems to occur in high load environments (like github actions) sometimes, for unclear reasons. I was able to reproduce this locally on my laptop as well if the test run happened under a lot of CPU stress. Because of this, I've widened the e2e test criteria to accept both possibilities (stream closing abnormally, or silent termination with a half finished stream) to unblock folks.
I will do some investigation, figure out what is going on here, and push a proper fix which stops this "silent termination" case from happening.