Repository navigation
fix(lk): say why no user resolves: the default user, or several users - #1075
Merged
Merged
Conversation
Topherhindman
force-pushed
the
auth-tests/lk-auth-scripts
branch
from
October 23, 2026 17:11
81c5844 to
7d625e4
Compare
Topherhindman
force-pushed
the
fix/lk-broken-default-user-message
branch
from
October 23, 2026 17:11
b079635 to
485185d
Compare
Topherhindman
force-pushed
the
auth-tests/lk-auth-scripts
branch
from
October 23, 2026 17:53
7d625e4 to
e07a424
Compare
Topherhindman
force-pushed
the
fix/lk-broken-default-user-message
branch
from
October 23, 2026 17:53
485185d to
5afd2a7
Compare
When no user could act on the target Public API, resolveSessionUser always said "no user is signed in", even when the default user was signed in elsewhere or two users were signed in there. It now says which: - two or more users on that API and none is the default: pass --user to pick one; - the default user is signed in to another API: names it and that API; - the default user isn't signed in anywhere: names it. "No user is signed in" is left for when that's true. An explicit --user already has its own errors and is unaffected.
Topherhindman
force-pushed
the
fix/lk-broken-default-user-message
branch
from
October 23, 2026 19:39
5afd2a7 to
5f790ea
Compare
u9g
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no user could act on the target Public API,
resolveSessionUseralways said "no user is signed in", even when the default user was signed in elsewhere or two users were signed in there. It now says which:2 users are signed in to … and none is the default user; pass --user to pick one;LIVEKIT_API_URLpoints away from it:the default user "u_1" is signed in to <its API>, not <target> (run … to sign in there);the default user "gone@example.com" is not signed in to <target> (run … to sign in)."No user is signed in" is left for when that's true. An explicit
--useralready has its own errors and is unaffected.Testing:
broken-default-user.txtardrops its known-bug skip and matches the new message.two-users-same-api.txtardrops its known-bug skip and checks for the--userhint.TestRequireUserSessionAPIURLgains the different-API case.cmd/lkpasses.