Repository navigation
Conversation
The request never selected manager_get_frame_cryptors, so the FFI rejected it and frameCryptors() always threw. Fixes livekit#299 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
There was a problem hiding this comment.
🟢 Approval recommended
The narrow fix addresses the reported FFI request defect, includes regression coverage, and leaves no unresolved review findings.
No open issues 🎉
What changed in this PR
Fixes #299 by selecting the required FFI operation in E2EEManager::frameCryptors(), preventing rejection of an empty E2EE request.
Changes:
- Selects
manager_get_frame_cryptorsbefore sending the request. - Adds an integration regression test that publishes an encrypted audio track and checks for the local participant’s cryptor.
| File | Description |
|---|---|
src/tests/integration/test_e2ee.cpp |
Adds regression coverage for retrieving frame cryptors after publishing. |
src/e2ee.cpp |
Selects the missing frame-cryptor request operation. |
Review effort: Balanced
|
|
||
| // The track's cryptor may be created after publishing returns. | ||
| bool found = false; | ||
| const auto deadline = std::chrono::steady_clock::now() + 5s; |
Collaborator
There was a problem hiding this comment.
is 5s an appropriate deadline? since the creation is all local i would expect <1s. Curious if you tried lower number with/out success?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #299
What changed
E2EEManager::frameCryptors()now selects themanager_get_frame_cryptorsrequest. Without it, the FFI received anE2eeRequestwith no message, rejected it (InvalidRequest("message is empty")), andframeCryptors()threw.frameCryptors()includes the local participant's cryptor.Testing
Ran on Linux x86_64 against
livekit-server --dev:E2EEIntegrationTest.FrameCryptorsIncludePublishedTrackfails (frameCryptors()throws).🤖 Generated with Claude Code