Repository navigation
LK Capture integration - #276
Merged
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
stephen-derosa
commented
Oct 9, 2026
stephen-derosa
commented
Oct 12, 2026
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
stephen-derosa
force-pushed
the
sderosa/capture-no-device-source
branch
4 times, most recently
from
October 13, 2026 17:15
a21d2ec to
4c67c5a
Compare
Contributor
There was a problem hiding this comment.
Devin Review found 1 new potential issue.
5 flags not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)
stephen-derosa
force-pushed
the
sderosa/capture-no-device-source
branch
from
October 13, 2026 20:48
1f16247 to
31d42b2
Compare
stephen-derosa
force-pushed
the
sderosa/capture-no-device-source
branch
from
October 14, 2026 16:32
29ddf8f to
a990fad
Compare
Collaborator
Author
|
todo: cherry-pick Done |
stephen-derosa
force-pushed
the
sderosa/capture-no-device-source
branch
from
October 19, 2026 17:36
a335556 to
a01fc94
Compare
This was referenced Oct 19, 2026
alan-george-lk
approved these changes
Oct 23, 2026
alan-george-lk
left a comment
alan-george-lk
left a comment
Collaborator
There was a problem hiding this comment.
Approve pending CI working on latest Rust release
stephen-derosa
force-pushed
the
sderosa/capture-no-device-source
branch
from
October 23, 2026 21:20
171f99d to
e625513
Compare
* Additional API mods for redesign * Self-review bundle of changes * Consolidate cmake vars * Address devin.ai join throwing warning
stephen-derosa
force-pushed
the
sderosa/capture-no-device-source
branch
from
October 27, 2026 17:41
e625513 to
3757652
Compare
stephen-derosa
commented
Oct 27, 2026
stephen-derosa
commented
Oct 27, 2026
stephen-derosa
commented
Oct 27, 2026
stephen-derosa
commented
Oct 27, 2026
stephen-derosa
commented
Oct 27, 2026
stephen-derosa
force-pushed
the
sderosa/capture-no-device-source
branch
from
October 27, 2026 22:59
cf8f2a8 to
709ac96
Compare
stephen-derosa
commented
Oct 27, 2026
| #include "room.pb.h" | ||
|
|
||
| #if LIVEKIT_CAPTURE_ENABLED | ||
| #include "livekit/capture/capture_source.h" |
Collaborator
Author
There was a problem hiding this comment.
not sure why codex lumped this in here...
stephen-derosa
force-pushed
the
sderosa/capture-no-device-source
branch
from
October 27, 2026 23:18
0ad1cb6 to
b01318f
Compare
Collaborator
Author
|
need to merge: livekit/rust-sdks#1584, cut a release, then point rust-sdks to said release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#227 minus device capture source and addressing comments.
This implementation assumes that the livekit capture build is behind a build arg which would bring in gstreamer deps (very large)