Skip to content

keybindings.js: Skip invalid custom-list entries instead of aborting setup - #14042

Open
dualfroz wants to merge 1 commit into
linuxmint:masterfrom
dualfroz:fix/14027-custom-keybinding
Open

dualfroz wants to merge 1 commit into
linuxmint:masterfrom
dualfroz:fix/14027-custom-keybinding

Conversation

@dualfroz

Copy link
Copy Markdown

Fixes #14027. Entries in custom-list that don't form a valid GSettings path are now skipped with a warning instead of throwing on a null Gio.Settings, which aborted KeybindingManager._init() before media keys were set up and dropped the remaining custom shortcuts when the list changed at runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Malformed entry in custom-list aborts KeybindingManager._init() and leaves all keybindings (media keys included) unbound

1 participant