Repository navigation
nvme-print-json: list only the supported events of the persistent event log - #4229
Merged
Merged
Conversation
…nt log json_add_bitmap() added a key for every event of a non-zero byte of the Supported Events Bitmap, but filled in its value only for the supported ones. The other keys got the uninitialized stack buffer, so "nvme log persistent-event -o json" printed random bytes. List the supported events only, as the normal output does. Signed-off-by: Daniel Wagner <dwagner@suse.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
json_add_bitmap()added a key for every event of a non-zero byte of the Supported Events Bitmap of the persistent event log, but filled in its value only for the supported events. The other keys got the uninitialized stack bufferevt_str, sonvme log persistent-event -o jsonprinted random bytes, different on every run.List the supported events only, as the normal output does.
Found by comparing the output of the print test with and without the decoder sandbox (#4183): the random bytes differed between the two runs. #4183 carries the same commit, as its comparison test depends on it.
Testing:
bitmap_0,bitmap_1, ... with uninitialized values)