Repository navigation
ocp: Fix OCP telemetry timestamp field decode - #4226
Merged
Merged
Conversation
The decoded timestamp value is incorrect because bytes 6 and 7 of the timestamp field used for timestamp attributes are not masked off. test: cover OCP telemetry timestamp attributes Added test with non-zero values in timestamp bytes 6 and 7 to verify change. Signed-off-by: Jeff Lien <jeff.lien@sandisk.com> Reviewed-by: Brandon Paupore <brandon.paupore@sandisk.com>
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix matches the timestamp layout and includes regression coverage for the reported error.
No open issues 🎉
What changed in this PR
Fixes OCP telemetry timestamp decoding by excluding the two attribute bytes from the timestamp value.
Changes:
- Decodes the timestamp as a 48-bit value.
- Adds regression coverage with nonzero attribute bytes and an expected formatted timestamp.
| File | Description |
|---|---|
| tests/cli/ocp/ocp_internal_log_mock_test.py | Adds timestamp attribute regression coverage. |
| src/field-parser.c | Extracts the timestamp without attribute bytes. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The decoded timestamp value is incorrect because bytes 6 and 7 of the timestamp field used for timestamp attributes are not masked off.
test: cover OCP telemetry timestamp attributes
Added test with non-zero values in timestamp bytes 6 and 7 to verify change.
Reviewed-by: Brandon Paupore brandon.paupore@sandisk.com