Repository navigation
Disable network tests whose endpoints or data are gone; fix is_up - #114
Merged
Merged
Conversation
With SKIP_EXTERNAL_URLS off, five tests failed against external services: - test_named_graph_types: graphdb.dumontierlab.com ncats-red-kg returns 502 - test_infer_setting: graph.fhircat.org has no fhirontology repository and no Patient/pat4 in any remaining repository - test_observation_online: hl7.org dropped the haplotype2 example after R4; the R4/R4B/STU3 ShEx references undefined fhirpath shapes or won't parse - test_wikidata_reactome, test_diseases: live Wikidata no longer fits the 2018/2019 schemas; shex.js agrees with PyShEx on the saved snapshots is_up() treated any HTTP response, including 502 and 404, as up, and is_down_reason() named the last pre-cached server instead of its argument. Also restores the Wikidata disease snapshots that c6ac2dc (#113) accidentally committed after a local network test run overwrote them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI runs with
SKIP_EXTERNAL_URLS=true, so these only fail locally, but a full local run had 5 failures. For each I looked for an alternate source before disabling it.test_sparql_options::test_named_graph_typesgraphdb.dumontierlab.com/repositories/ncats-red-kgreturns 502test_sparql_options::test_infer_settinggraph.fhircat.orgno longer has thefhirontologyrepositorytest,test2,example2,ontest) have noPatient/pat4test_fhir::test_observation_onlinehl7.org/fhir/observation-example-haplotype2.ttlis 404observation.shexand fullfhir.shexreference undefinedfhirpathshapes; R4B and STU3 schemas don't parse. The offlinetest_observationstill covers this case.test_reactome,test_diseasesAll five are now
pytest.mark.skipwith a reason.is_upfix: it treated any HTTP response, including 502 and 404, as "up", which is why the dead GraphDB endpoints weren't auto-skipped. It now treats 5xx and 404 as down.is_down_reason()also always named the last pre-cached server rather than its argument.Snapshot restore: #113 accidentally included 8 rewritten files under
tests/test_issues/data/wikidata/disease/. A local run with network tests on overwrote them (the Wikidata tests save fetched graphs over the committed snapshots), andgit commit -apicked them up. This restores them; nothing reads them.Testing: full suite with
SKIP_EXTERNAL_URLS=false: 451 passed, 70 skipped, 0 failed.🤖 Generated with Claude Code