Skip to content

Increase default channel heartbeat to 10 minutes. #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 1 commit into from
Oct 15, 2026
+2 −2
Merged

Increase default channel heartbeat to 10 minutes. #967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/bitcoin/network/settings.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ struct BCT_API settings
bool gossip_i2p{ false };
uint32_t identifier{ 0 };
uint32_t handshake_timeout_seconds{ 15 };
uint32_t channel_heartbeat_minutes{ 5 };
uint32_t channel_heartbeat_minutes{ 10 };
uint32_t maximum_skew_minutes{ 120 };
std::string user_agent{ BC_USER_AGENT };
system::config::path path{};
Expand Down
2 changes: 1 addition & 1 deletion test/settings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ BOOST_AUTO_TEST_CASE(settings__construct__default__expected)
BOOST_REQUIRE_EQUAL(instance.connect_timeout_seconds, 5u);
BOOST_REQUIRE_EQUAL(instance.outbound.connect_timeout_seconds, 0u);
BOOST_REQUIRE_EQUAL(instance.handshake_timeout_seconds, 15u);
BOOST_REQUIRE_EQUAL(instance.channel_heartbeat_minutes, 5u);
BOOST_REQUIRE_EQUAL(instance.channel_heartbeat_minutes, 10u);
BOOST_REQUIRE_EQUAL(instance.maximum_skew_minutes, 120u);
BOOST_REQUIRE_EQUAL(instance.rate_limit, 0u);
BOOST_REQUIRE_EQUAL(instance.user_agent, BC_USER_AGENT);
Expand Down
Loading