Repository navigation
Refine the batch rule for restoring unreachable addresses. - #966
Open
echennells wants to merge 1 commit into
Open
echennells wants to merge 1 commit into
echennells wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies your answers to the #942 questions (posted on #924).
A timeout attributes nothing. A timed-out address is already restored through its socket, so it no longer counts against restoring its unreachable batch members. With the gateway gone, connects wait about 3s for ARP before
EHOSTUNREACHwhile the connect timer is 2.5-5s, so most such batches saw a timeout first and dropped.A single failure is not evidence of a local outage. Unreachable members are now restored only if at least two members drew an address and none was attributable. Members that drew no address are not counted. With
connect_batch_size = 1an unreachable address is dropped again, as before #942, and #924 reseeds if the pool drains.Tests: the single-code unreachable tests use a batch of two; new tests cover a batch of one and a batch in which only one member drew an address; the timeout test now expects both members restored.