fix(server): stop telling generated projects to link the framework via yalc - #119
Merged
Merged
Conversation
…a yalc `lt server create` writes README.md from `nest-server-starter/README.md.ejs`. Its "Test & debug the NestServer package" section still described yalc and `npm run watch`, a way nest-server-starter dropped long ago. In vendor mode the section was meaningless, not merely stale: there is no `@lenne.tech/nest-server` package to link, the core lives in `src/core/`. - npm mode names only the starter's `link:nest-server` / `unlink:nest-server` scripts. Their names are stable, their implementation is being ported to Node, so the README says nothing about how they work. - vendor mode points at `src/core/VENDOR.md`, the modification policy and the update / contribute commands instead. - `setupServer` passes `vendor` into the template. `lt fullstack init` does not render this template and is unaffected. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
lt server createwrites the project'sREADME.mdfromsrc/templates/nest-server-starter/README.md.ejs. Its "Test & debug the NestServer package" section still described yalc andnpm run watch. nest-server-starter dropped that way long ago. Today it usespnpm run link:nest-server/unlink:nest-server, and their implementation is currently being ported to Node.In vendor mode (
lt server create --framework-mode vendor) the same section was not merely stale but meaningless. There is no@lenne.tech/nest-serverpackage to link, because the core is insrc/core/.lt fullstack initdoes not render this template and keeps the starter's own README.What changed
pnpm run link:nest-server, thenpnpm run unlink:nest-server. The README names the scripts but says nothing about how they work, so the Node port cannot make it stale again.src/core/VENDOR.md, says project code belongs outsidesrc/core/, and names/lt-dev:backend:update-nest-server-coreand/lt-dev:backend:contribute-nest-server-core.setupServerpassesvendor: frameworkMode === 'vendor'into the template.Test
__tests__/server-readme-template.test.tsrenders both modes and checks thatsetupServerpasses the mode into the template. Mutations:vendorprop not passednpm test: 79 suites, 1215 tests. Lint and tsc are clean.Not covered here: the
lt-devplugin'scontributing-to-lt-frameworkskill describes a third way (pnpm link --global). That lives in the plugin repo and has been reported there.🤖 Generated with Claude Code