Repository navigation
Conversation
Split embedded CDATA terminators across adjacent sections and add document/direct printer round-trip regression tests. Fixes leethomason#1097.
Adapt ByteAsk web review and test-design suggestions to exercise repeated and suffix-only CDATA terminators with the FILE-backed XMLPrinter. Local C++11 and ASan/UBSan suites pass 576 tests.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CDATA text containing
]]>currently produces malformed XML. Split each embedded terminator across adjacent CDATA sections, preserving the complete text for both document serialization and directXMLPrinter::PushTextcalls.For example,
a]]>bnow serializes as<r><![CDATA[a]]]]><![CDATA[>b]]></r>.Fixes #1097.
Validation:
-Wall -Wextra -Werror -pedantic: 576 tests passed, 0 failed.AI assistance: Codex helped implement and validate the change. ByteAsk web reviewed the algorithm and helped design the FILE-backed regression tests; I adapted those suggestions and compiled and ran the tests locally.