Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inputs such as
</data>, an XML declaration followed by</data>, or<data/>followed by</data>currently return XML_SUCCESS. When ParseDeep encounters a closing element without a parent end-tag recipient, report XML_ERROR_MISMATCHED_ELEMENT at that closing tag's line and return failure. Nested closing-tag transfer and node cleanup stay unchanged.Fixes #972.
Regression coverage includes closing tags after a declaration, a root, text, and comments, plus document cleanup/reuse and accepted fragment controls. The older #291 crash test uses the malformed input
�</a>; it now expects a mismatch and still calls Print. A separate accepted<a>�</a>control retains coverage of lazy numeric-reference processing during printing.Validation on Ubuntu with GCC 13.3:
The behavior change is limited to unmatched document-level closing tags. Existing supported text/multiple-element fragments remain accepted; no public API or ABI changes are introduced.