Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With absolute
CMAKE_INSTALL_LIBDIRorCMAKE_INSTALL_INCLUDEDIR, CMake installs tinyxml2 to the requested location, buttinyxml2.pcprepends the install prefix again. A downstream pkg-config consumer then fails to find the installed header or library.Keep absolute install directories unchanged and retain
${prefix}/${exec_prefix}for relative directories. Add a metadata regression test and an absolute-directory configuration to the existing CI matrix.Validated on master
8224e427b655b83dae5e2298f1e6919523a78737, Linux x86_64, GCC 14.2.0, CMake 3.31.6 and pkg-config 1.8.1:find_packagetests pass in static/shared Debug/Release. Each xmltest run reports 528 passed, zero failed.DESTDIR/PKG_CONFIG_SYSROOT_DIR, and prefix overrides.Windows, macOS and CMake 3.15 were not run locally. The existing CI matrix covers those environments; remote CI has not run for this patch.