Repository navigation
Conversation
fhgffy
marked this pull request as ready for review
October 3, 2026 23:41
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an element starts with comments,
SetText()currently inserts a new text node before the comments and leaves the previous value in the tree. For<foo><!--comment-->old</foo>, setting"new"serializes as<foo>new<!--comment-->old</foo>.Skip leading comments when selecting the text node, matching
GetText(), and replace that existing node. Keep first-child insertion when no text node follows the comments. Add regression coverage for consecutive comments, mixed content, CDATA, numeric setters, and the insertion fallback, and update theSetText()documentation.Fixes #927.
Validation on Windows with GCC 15.1.0, CMake 4.3.2, and Ninja 1.13.2:
8224e427b655b83dae5e2298f1e6919523a78737(exit 1) and passes with the fix (exit 0).