Skip to content

refactor(Combinatorics/SimpleGraph): reuse leaf connectivity proof - #45091

Open
Fieldnote-Echo wants to merge 4 commits into
leanprover-community:masterfrom
Fieldnote-Echo:NSpe/leaf-connectivity
Open

Fieldnote-Echo wants to merge 4 commits into
leanprover-community:masterfrom
Fieldnote-Echo:NSpe/leaf-connectivity

Conversation

@Fieldnote-Echo

Copy link
Copy Markdown
Contributor

While reviewing the graph API, I noticed that the proof of

Connected.induce_compl_singleton_of_degree_eq_one

can be shortened using

Preconnected.induce_of_degree_eq_one (s := {v}ᶜ)

The unique neighbor handles nonemptiness. This removes the duplicate proof and moves the lemma from Acyclic to Connectivity.Connected. No API changes required, and the lemma can be imported without Acyclic.


Discussed on Zulip: reusing the leaf-deletion proof.

AI assistance: Codex helped search the local API, adapt the proof, and run local checks.

@github-actions github-actions Bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Oct 20, 2026
@github-actions

Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to Zulip and join the Lean community.
Thank you again for joining our community.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

PR summary d946308a98

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

✅ Lean-aware diff — post-build, computed from the Lean environment (commit d946308).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.
No changes to weak technical debt.

Current commit d946308a98
Reference commit d4acc3be57

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-combinatorics Combinatorics label Oct 20, 2026
Comment thread Mathlib/Combinatorics/SimpleGraph/Connectivity/Connected.lean Outdated
Co-authored-by: Jeremy Tan Jie Rui <54175463+Parcly-Taxel@users.noreply.github.com>
@Fieldnote-Echo

Copy link
Copy Markdown
Contributor Author

LLM-generated

@github-actions github-actions Bot added the LLM-generated PRs with substantial input from LLMs - review accordingly label Oct 20, 2026
Comment thread Mathlib/Combinatorics/SimpleGraph/Connectivity/Connected.lean Outdated
Co-authored-by: Snir Broshi <26556598+SnirBroshi@users.noreply.github.com>
Comment thread Mathlib/Combinatorics/SimpleGraph/Connectivity/Connected.lean Outdated
Co-authored-by: Snir Broshi <26556598+SnirBroshi@users.noreply.github.com>

@SnirBroshi SnirBroshi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer merge

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by SnirBroshi.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Oct 21, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LLM-generated PRs with substantial input from LLMs - review accordingly maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-combinatorics Combinatorics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants