Repository navigation
fix(AIC-3679): bump brotlicffi to 1.2.1.0 for GHSA-9v8h-qqgm-4m35 - #219
Merged
Merged
Conversation
brotlicffi before 1.2.1.0 has an out-of-bounds write in the Brotli decoder. Raise the dev-group floor to >=1.2.1.0 and relock. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
apucacao
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
brotlicffi before 1.2.1.0 has an out-of-bounds write in the Brotli decoder (GHSA-9v8h-qqgm-4m35, affected range
>=1.0.3, <1.2.1.0). This PR raises the floor in the rootdevdependency group from>=1.0to>=1.2.1.0and relocks only that package withuv lock --upgrade-package brotlicffi.pyproject.toml:brotlicffi>=1.2.1.0uv.lock: brotlicffi 1.2.0.1 → 1.2.1.0. The lockfilerevisiongoes from 3 to 5 because the lock was written with uv 0.13.5. CI'ssetup-uv@v5installs the latest uv, so it can read revision 5.Scope: no published package declares brotlicffi. The only consumer is the workspace dev group, so released wheels are unaffected and this PR changes dev and CI environments only.
Jira: AIC-3679
Testing
uv lock --checkpasses, anduv sync --all-packagesinstalls brotlicffi 1.2.1.0ruff checkandruff format --checkare cleanuv run pytest: 3449 passed, 18 skipped, 2 failed. Both failures are inpackages/client/tests/test_lifecycle.py::TestInitClientSDKKeyPath(test_uses_options_sdk_key_over_env_varandtest_retries_after_a_failed_init_instead_of_replaying_it). The same 2 tests fail on the pre-bump lockfile with brotlicffi 1.2.0.1, and the file passes when run alone (60/60). They look like state leaking between tests, and this change did not cause them.🤖 Generated with Claude Code
Note
Overview
Raises the workspace dev dependency floor for
brotlicffifrom>=1.0to>=1.2.1.0and relocksuv.lockso CI/dev installs 1.2.1.0 instead of 1.2.0.1. This addresses GHSA-9v8h-qqgm-4m35 (out-of-bounds write in the Brotli decoder). The lockfile revision also advances (3 → 5) from the uv version used when relocking.Scope:
brotlicffiis only declared in the root dev group—not in shipped packages—so released wheels are unchanged; only local dev and CI dependency resolution are affected.Reviewed by Cursor Bugbot for commit 4867d48. Bugbot is set up for automated code reviews on this repo. Configure here.