Repository navigation
fix(projects): roll forward to the new AI SDK - #220
Merged
Merged
Conversation
- Save the application key as LD_SDK_KEY, the variable the Python and Node.js AI SDKs read, instead of LAUNCHDARKLY_SDK_KEY. - Verify the key with the AI SDK's init_client() / initClient() in Python and Node.js, with the outcomes for valid, invalid and missing keys. - Fix the env-config verify_sdk_key helper, which built a Config but never applied it, so it always failed. - Point the next-step links at the sdk-install skill; the sdk skill does not exist.
Skill eval results
Only suites whose source actually changed since their last recorded score were re-run. Soft-failing while we stabilise the baseline. |
1 of 2 tasks
jeffdupont
approved these changes
Oct 26, 2026
jeffdupont
left a comment
jeffdupont
left a comment
There was a problem hiding this comment.
Correct, and the only PR in this set whose install line includes launchdarkly-server-sdk. Two small nits below, neither blocking.
Create and fetch projects with the MCP tools, explain that SDK keys come from the UI or REST, drop the untyped getClient().initialized() call, and note that verify_sdk_key is for standalone scripts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LAUNCHDARKLY_SDK_KEYtoLD_SDK_KEYthroughout; the AI SDKs read onlyLD_SDK_KEY.init_client/get_client().is_initialized()/shutdown().env-config.mdverify_sdk_keyuses the new SDK.Jira: DEVREL-1646
Testing
Verification cell prints
Truewith a valid key andFalsewith an invalid one.Notes
launchdarkly-ai-server0.3.0 (Python) and@launchdarkly/ai-node0.3.0 (Node.js).skills.json, so later merges may needpython3 scripts/generate_catalog.pyre-run.Note
Overview
Bumps the projects skill to 0.5.0 and aligns its docs with the LaunchDarkly AI SDK and hosted MCP workflow.
Credentials and access: Prerequisites now require the remotely hosted MCP server; API tokens with
projects:writeare only for scripts, IaC, and admin tools. Agent steps emphasize MCPcreate-project/get-project/list-projects, and explain that MCP does not return server-side SDK keys (UI copy or REST with a user-supplied token).Env convention: All examples and automation snippets rename
LAUNCHDARKLY_SDK_KEY→LD_SDK_KEY, with explicit note that Python/Node AI SDKs read onlyLD_SDK_KEY.Verification: Setup verification replaces classic
ldclientsamples withlaunchdarkly-ai-serverand@launchdarkly/ai-node(init_client,get_client().is_initialized(),shutdown()), including expected outcomes for valid, invalid, and missing keys.env-config.md’sverify_sdk_keyfollows the same async AI SDK pattern.Navigation: Related/next-step links point at
sdk-installinstead ofsdk. Catalog entry inskills.jsonmatches the new version and compatibility text.Reviewed by Cursor Bugbot for commit ef47ff1. Bugbot is set up for automated code reviews on this repo. Configure here.