Repository navigation
fix(category): store ancestors and cascade deletes - #448
Merged
Merged
Conversation
Ancestors were derived at read time in postProcessResource, which storage expand bypasses: a category expanded from another resource (e.g. product-projections?expand=categories[*]) always had `ancestors: []`. They are now stored as references on create and kept in sync on changeParent, so the generic expand resolves `ancestors[*]` and the post-processing hack is gone. Deleting a category now also deletes its descendants and removes them from products, matching commercetools. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 49bb391 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jsm1t
approved these changes
Oct 13, 2026
Merged
BramKaashoek
pushed a commit
that referenced
this pull request
Oct 13, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @labdigital/commercetools-mock@5.0.3 ### Patch Changes - [#448](#448) [`58b01d7`](58b01d7) Thanks [@BramKaashoek](https://github.com/BramKaashoek)! - Store category ancestors so they expand from other resources, and delete a category's subtree (removing it from products) like commercetools does Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category.ancestorswas computed inpostProcessResource, which storage expand skips, so categories expanded from another resource (e.g.product-projections?expand=categories[*]) always hadancestors: []. Ancestors are now stored as references on create and onchangeParent(descendants included); the generic expand handlesancestors[*], so the post-processing hack is removed.🤖 Generated with Claude Code