[yue9944882]

Bug

LeaderElectionRecord.equals() has a field typo in the final branch of its equals chain:

if (renewTime == null) {
  return that.holderIdentity == null;   // compares the wrong field
}
return renewTime.equals(that.renewTime);

When this.renewTime == null, the method returns whether that.holderIdentity is null instead of whether that.renewTime is null. Consequences:

• Two otherwise-equal records that both have a null renewTime are reported unequal (because holderIdentity is typically non-null).
• A record with a null renewTime can be reported equal to one with a non-null renewTime when holderIdentity happens to be null.

This has been present since the original 2019 leader-election commit. equals() is used by LeaderElector.tryAcquireOrRenew() to detect observed-record changes, so a wrong result can skew the observedTime bookkeeping that drives lease-expiry decisions.

Fix

Compare renewTime in that branch (minimal one-line change):

if (renewTime == null) {
  return that.renewTime == null;
}

Verification

Added LeaderElectionRecordTest with two focused cases (equal when both renewTime null; unequal when only one is null). Verified the first test fails before the fix and passes after:

• Before fix: Tests run: 2, Failures: 1 (equalWhenRenewTimeIsNullOnBoth fails)
• After fix: Tests run: 2, Failures: 0
• No regression: existing LeaderElectionTest (6) and LeaderElectorTest (3) still pass.

Ran: ./mvnw -pl extended -am test -Dtest=LeaderElectionRecordTest -Dsurefire.failIfNoSpecifiedTests=false

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [yue9944882]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: yue9944882 / name: Min Jin (1a1ccd9)