Repository navigation
Add exec credential plugin policy (kuberc credentialPluginPolicy semantics) - #4951
Draft
brendandburns with Copilot wants to merge 1 commit into
Draft
brendandburns with Copilot wants to merge 1 commit into
brendandburns with Copilot wants to merge 1 commit into
Conversation
Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Copilot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kubeconfig
execcredential plugins start local processes, and the Java client had no way to restrict them. This adds an application-controlled policy, like kubernetes-client/csharp#1930. Its semantics follow kubectl's kuberc credential plugin policy and client-go's matching logic.Policy (
ExecCredentialPluginPolicy)ALLOW_ALL(the default, so behaviour is unchanged),DENY_ALL, andallowlist(...).exec.go): an entry matches if it is exactly equal to the cleaned plugin command, or if both resolve throughPATH(LookPath-style) to the same executable.PATHdirectories are skipped, matching Go'sErrDot.PATHEXTis handled.PATHlookup at process start.ValidatePluginPolicy):./foois rejected);Allowlistpolicy is rejected;kuberc loading
fromKubeRc(Reader | File)parses akubectl.config.k8s.io/*Preferencedocument. It acceptsnameas the deprecated alias forcommandand rejects entries that set both.fromDefaultKubeRc()finds the file the way kubectl does:KUBECTL_KUBERC=falseorKUBERC=offdisables kuberc, which means allow all.$KUBERCfile must exist and be valid.~/.kube/kubercis ignored. One that isn't valid YAML is ignored with a warning, as kubectl does. One that parses but has an invalid policy is a hard error.Enforcement
KubeConfig.setExecCredentialPluginPolicy(...). The check runs inrunExecbefore the process starts, after the existing kubeconfig-relative path resolution.ExecCredentialPluginDeniedException, aRuntimeExceptionwithgetCommand(). The exception propagates out ofgetCredentials(), so it fires both when the client is built and on token refresh throughKubeconfigAuthentication.ClientBuilder.standard(policy)andClientBuilder.standard(persistConfig, policy).Review notes
enventries are still passed to the plugin. Rejecting them would not match kubectl and would break common plugins (for example ones that rely onAWS_PROFILE). The README describes the policy as defense in depth, not a sandbox.