Skip to content

Remove dependency on FluentAssertions - #1973

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes-client:masterfrom
dallmair:feat/remove-fluentassertions
Oct 23, 2026
Merged

kubernetes-prow[bot] merged 1 commit into
kubernetes-client:masterfrom
dallmair:feat/remove-fluentassertions

Conversation

@dallmair

Copy link
Copy Markdown
Contributor

Closes #1972

Copilot AI balanced review requested due to automatic review settings October 21, 2026 19:29
@linux-foundation-easycla

linux-foundation-easycla Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: dallmair / name: Thomas Dallmair (141fcc7)

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 21, 2026
@kubernetes-prow

Copy link
Copy Markdown

Welcome @dallmair!

It looks like this is your first PR to kubernetes-client/csharp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/csharp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 21, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused replacements preserve test behavior, and no unresolved issues remain.

No open issues 🎉

What changed in this PR

Removes FluentAssertions from the test suite, addressing #1972’s licensing concern while preserving assertion behavior.

Changes:

  • Replaces FluentAssertions assertions with xUnit equivalents.
  • Removes the package reference and centrally managed version.
File Description
tests/​KubernetesClient.Tests/​TokenFileAuthTests.cs Converts token assertions to xUnit.
tests/​KubernetesClient.Tests/​OidcAuthTests.cs Converts OIDC assertions, preserving expiry tolerance.
tests/​KubernetesClient.Tests/​KubernetesClient.Tests.csproj Removes the FluentAssertions dependency.
Directory.Packages.props Removes the FluentAssertions version entry.

Review effort: Balanced

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 21, 2026
@brendandburns

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2026
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, dallmair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit b008880 into kubernetes-client:master Oct 23, 2026
10 checks passed
@dallmair
dallmair deleted the feat/remove-fluentassertions branch October 23, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dependency on FluentAssertions

3 participants