Repository navigation
Remove dependency on FluentAssertions - #1973
kubernetes-prow[bot] merged 1 commit into
Conversation
|
|
|
Welcome @dallmair! |
There was a problem hiding this comment.
🟢 Approval recommended
The focused replacements preserve test behavior, and no unresolved issues remain.
No open issues 🎉
What changed in this PR
Removes FluentAssertions from the test suite, addressing #1972’s licensing concern while preserving assertion behavior.
Changes:
- Replaces FluentAssertions assertions with xUnit equivalents.
- Removes the package reference and centrally managed version.
| File | Description |
|---|---|
| tests/KubernetesClient.Tests/TokenFileAuthTests.cs | Converts token assertions to xUnit. |
| tests/KubernetesClient.Tests/OidcAuthTests.cs | Converts OIDC assertions, preserving expiry tolerance. |
| tests/KubernetesClient.Tests/KubernetesClient.Tests.csproj | Removes the FluentAssertions dependency. |
| Directory.Packages.props | Removes the FluentAssertions version entry. |
Review effort: Balanced
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, dallmair The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b008880
into
kubernetes-client:master
Closes #1972