Repository navigation
Cap a whole-segment run of stars at ** in glob filters [patch] - #206
Open
matt-edmondson wants to merge 1 commit into
Open
matt-edmondson wants to merge 1 commit into
matt-edmondson wants to merge 1 commit into
Conversation
A whole-segment run of three or more stars (`***/x.cs`, `a/***/c`) was kept at full length, so ExpandGlobStarSegments left a stray joined star in front of `**` and the pattern matched nothing. Odd runs failed while even runs happened to split into clean `**` segments. Cap the run at two stars. Fixes #205 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW41ENCbvstBVNMiaBJ
Contributor
Author
|
Generated by Claude Code |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #205
What was wrong
CollapseJoinedGlobStarscollapsed a joined run of stars to*but kept a whole-segment run at full length.***/stayed***/, soExpandGlobStarSegmentsfound**at offset 1 and left a stray*joined to it, and DotNet.Glob matched nothing.***/x.cs,***/banda/***/cmatched nothing (and-***/tmpexcluded nothing), while****/bhappened to work because it splits into two clean**.Change
A whole-segment run is now capped at two stars (
Math.Min(runLength, 2)), as the issue suggests. The comment above the method now says so.Tests
WholeSegmentStarRunMatchesLikeGlobStar: the issue's cases, plus runs of 4 and 5, zero-segment forms (x.csvs***/x.cs,a/cvsa/***/c) and the joined***x.cscontrol.WholeSegmentStarRunStillRequiresTheLiteralandWholeSegmentStarRunExclusionExcludesItems(-***/tmp).CollapseJoinedGlobStarsLeavesWholeSegmentsAndClassesrows:***/x.cs→**/x.cs,a/*****/c→a/**/c,***→**, andx[***]left as a class.Generated by Claude Code