Skip to content

ci(web): publish WASM demo to GitHub Pages from main - #7

Merged
knowlet merged 1 commit into
mainfrom
fix/wasm-pages-ci-20260916
Sep 16, 2026
Merged

knowlet merged 1 commit into
mainfrom
fix/wasm-pages-ci-20260916

Conversation

@knowlet

@knowlet knowlet commented Sep 16, 2026 •

Copy link
Copy Markdown
Owner

Publishes the existing verified WASM demo artifact on relevant pushes to main instead of leaving deployment manual-only.

Changes:

  • keep the existing build/output verification
  • deploy only from refs/heads/main
  • keep manual redeploy support on main
  • serialize Pages deployments without cancelling an in-flight production deploy

This should turn the currently skipped Pages deploy into an actual deployment after merge.

Summary by Sourcery

Publish the verified WebAssembly demo to GitHub Pages automatically from main while preserving safe, manual redeployments.

New Features:

  • Publish the verified WebAssembly demo to GitHub Pages on pushes to the main branch while retaining manual redeployment support.

Enhancements:

  • Serialize Pages deployments without cancelling in-progress production deployments.

CI:

  • Update the Pages workflow to deploy only from refs/heads/main after successful build and output verification.

Deployment:

  • Enable automatic GitHub Pages deployment for relevant main-branch updates.

Summary by cubic

Publishes the WASM demo to GitHub Pages on every push to main, replacing the previous manual-only deployment. The existing build verification stays, manual redeploy from main is still possible, and Pages deployments now serialize without cancelling an in-flight production deploy.

Written for commit 146e0ec. Summary will update on new commits.

Review in cubic

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@sourcery-ai

sourcery-ai Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The workflow now automatically publishes the verified browser WASM demo to GitHub Pages on relevant pushes to main, while preserving manual redeploys, restricting deployment to the main branch, and serializing production deployments without cancellation.

Flow diagram for verified WASM demo Pages deployment

flowchart LR
    Push[Push to main] --> Build[Build WASM demo]
    Manual[Manual redeploy] --> Build
    Build --> Verify[Verify static output]
    Verify --> Deploy{refs/heads/main}
    Deploy -->|yes| Pages[Deploy to GitHub Pages]
    Deploy -->|no| Skip[Skip deployment]
    Pages --> Serialized[Pages deployments serialized]
Loading

File-Level Changes

Change Details Files
Enable automatic GitHub Pages publication for verified WASM demo builds on the main branch while retaining manual redeployment.
  • Run deployment for events resolving to refs/heads/main, including pushes and manual dispatches.
  • Retain the existing build and output verification as the deployment prerequisite.
  • Remove the opt-in-only deployment behavior and update workflow documentation for automatic publishing.
.github/workflows/webdemo-pages.yml
Serialize GitHub Pages deployments without cancelling an active production deployment.
  • Use a shared pages concurrency group.
  • Allow queued runs to wait instead of cancelling an in-flight deployment.
.github/workflows/webdemo-pages.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Needs a human reviewer. Every push to main will now automatically publish the generated WASM site, so a bad build or workflow change can put broken content or an outage on the public GitHub Pages site. Reverting the workflow stops future deployments but does not retract an already published release; the site must be redeployed with a known-good artifact.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".github/workflows/webdemo-pages.yml">

<violation number="1" location=".github/workflows/webdemo-pages.yml:31">
P2: When this workflow is manually started from a non-main branch, its build still occupies the global `pages` concurrency group while `deploy` is skipped, so a main push can be delayed by an unrelated branch. Scope the group by `github.ref` or move concurrency to the deploy job.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

concurrency:
group: webdemo-pages-${{ github.ref }}
cancel-in-progress: true
group: pages

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: When this workflow is manually started from a non-main branch, its build still occupies the global pages concurrency group while deploy is skipped, so a main push can be delayed by an unrelated branch. Scope the group by github.ref or move concurrency to the deploy job.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/webdemo-pages.yml, line 31:

<comment>When this workflow is manually started from a non-main branch, its build still occupies the global `pages` concurrency group while `deploy` is skipped, so a main push can be delayed by an unrelated branch. Scope the group by `github.ref` or move concurrency to the deploy job.</comment>

<file context>
@@ -29,8 +28,8 @@ permissions:
 concurrency:
-  group: webdemo-pages-${{ github.ref }}
-  cancel-in-progress: true
+  group: pages
+  cancel-in-progress: false
 
</file context>
Suggested change
group: pages
group: pages-${{ github.ref }}

@knowlet
knowlet merged commit cc2cb59 into main Sep 16, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant