Repository navigation
ci(web): publish WASM demo to GitHub Pages from main - #7
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe workflow now automatically publishes the verified browser WASM demo to GitHub Pages on relevant pushes to main, while preserving manual redeploys, restricting deployment to the main branch, and serializing production deployments without cancellation. Flow diagram for verified WASM demo Pages deploymentflowchart LR
Push[Push to main] --> Build[Build WASM demo]
Manual[Manual redeploy] --> Build
Build --> Verify[Verify static output]
Verify --> Deploy{refs/heads/main}
Deploy -->|yes| Pages[Deploy to GitHub Pages]
Deploy -->|no| Skip[Skip deployment]
Pages --> Serialized[Pages deployments serialized]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. Every push to main will now automatically publish the generated WASM site, so a bad build or workflow change can put broken content or an outage on the public GitHub Pages site. Reverting the workflow stops future deployments but does not retract an already published release; the site must be redeployed with a known-good artifact.
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/webdemo-pages.yml">
<violation number="1" location=".github/workflows/webdemo-pages.yml:31">
P2: When this workflow is manually started from a non-main branch, its build still occupies the global `pages` concurrency group while `deploy` is skipped, so a main push can be delayed by an unrelated branch. Scope the group by `github.ref` or move concurrency to the deploy job.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| concurrency: | ||
| group: webdemo-pages-${{ github.ref }} | ||
| cancel-in-progress: true | ||
| group: pages |
There was a problem hiding this comment.
P2: When this workflow is manually started from a non-main branch, its build still occupies the global pages concurrency group while deploy is skipped, so a main push can be delayed by an unrelated branch. Scope the group by github.ref or move concurrency to the deploy job.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/webdemo-pages.yml, line 31:
<comment>When this workflow is manually started from a non-main branch, its build still occupies the global `pages` concurrency group while `deploy` is skipped, so a main push can be delayed by an unrelated branch. Scope the group by `github.ref` or move concurrency to the deploy job.</comment>
<file context>
@@ -29,8 +28,8 @@ permissions:
concurrency:
- group: webdemo-pages-${{ github.ref }}
- cancel-in-progress: true
+ group: pages
+ cancel-in-progress: false
</file context>
| group: pages | |
| group: pages-${{ github.ref }} |
Publishes the existing verified WASM demo artifact on relevant pushes to
maininstead of leaving deployment manual-only.Changes:
refs/heads/mainThis should turn the currently skipped Pages deploy into an actual deployment after merge.
Summary by Sourcery
Publish the verified WebAssembly demo to GitHub Pages automatically from main while preserving safe, manual redeployments.
New Features:
Enhancements:
CI:
Deployment:
Summary by cubic
Publishes the WASM demo to GitHub Pages on every push to main, replacing the previous manual-only deployment. The existing build verification stays, manual redeploy from main is still possible, and Pages deployments now serialize without cancelling an in-flight production deploy.
Written for commit 146e0ec. Summary will update on new commits.