Skip to content

fix: strip quotes from parsed package names - #156

Open
bytenik wants to merge 1 commit into
knope-dev:mainfrom
thinkalpha:fix/quoted-package-names
Open

bytenik wants to merge 1 commit into
knope-dev:mainfrom
thinkalpha:fix/quoted-package-names

Conversation

@bytenik

@bytenik bytenik commented Oct 23, 2026

Copy link
Copy Markdown

Changeset files generated by the JavaScript tooling quote package names, such as "@scope/package": patch. The parser currently keeps those delimiters in PackageName, so consumers cannot match these entries to the package's unquoted name.

Strip one matching pair of single or double quotes when parsing package names. Quoted and unquoted entries then contribute to the same release. Consume front-matter lines independently of the number of unique package names so duplicate normalized keys preserve the summary and retain last-entry-wins behavior.

This changes the parsed names exposed by the public API. A major changeset documents the compatibility change, and the format documentation describes quoted names.

Follows the parser-level fix suggested in knope-dev/knope#2051 (comment).

Validation:

  • All 12 tests pass with cargo test --locked.
  • The quoted-name and normalized-duplicate regressions fail against the original parser.
  • cargo clippy --locked --all-targets -- -D warnings, cargo +nightly fmt --check, and git diff --check pass.

@bytenik
bytenik marked this pull request as ready for review October 23, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant