Repository navigation
fix: upgrade react-router from 7.18.5 to 8.5.1 - #1121
Merged
Merged
Conversation
Move the guide example to react-router 8.5.1 so AIKIDO-2026-887720 is no longer in the lockfile. Co-authored-by: chris <chris@knock.app>
cursor
Bot
requested review from
kylemcd and
thomaswhyyou
and removed request for
a team
November 10, 2026 12:10
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1121 +/- ##
=======================================
Coverage 78.48% 78.48%
=======================================
Files 140 140
Lines 4508 4508
Branches 1314 1314
=======================================
Hits 3538 3538
Misses 873 873
Partials 97 97 |
andy-knock
approved these changes
Nov 10, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Vanta reports four open findings on the javascript repository. This PR fixes the one with a compatible release.
examples/guide-exampleis the only directreact-routerdependency. It requested^7.6.3, which resolved to 7.18.5. Aikido Intel marks 7.7.0 through 8.5.0 affected by AIKIDO-2026-887720:createRequestHandlercalleddecodeURIon the request path without a guard, so a malformed percent-encoding threwURIError. 8.5.1 catches that error and falls back to the raw path. There is no 7.x release after 7.18.5.The example uses declarative mode (
BrowserRouter,Routes,Route,Link), which 8.5.1 still exports fromreact-router. It already resolves React and React DOM to 19.3.1, which meets the 8.5.1 peer requirement of 19.2.7. The lockfile now resolvesreact-router@^8.5.1to 8.5.1 and dropscookie@1.0.2andset-cookie-parser@2.7.3, which only the 7.18.5 copy required.Linear: https://linear.app/knock/issue/KNO-16746/js-upgrade-react-router-from-7185-to-851
Addressed
react-router7.18.5 → 8.5.1 — remediate by 2026-12-25 — KNO-16746 — AikidoStill open, no compatible release
These stay on their triage tickets. Each patched release is a breaking major for the packages that request the current range.
glob13.0.7, fix recorded as 14.0.2 — KNO-16489minimatch9.0.9, fix recorded as 11.0.1 — KNO-16440yargs17.7.2, fix is yargs 18.1+ and 18 is ESM-only — KNO-16335Todos
None.
Checklist
No SDK behavior changed. The guide example's existing
react-routerimports typecheck against 8.5.1, and those exports load from the installed package.