Repository navigation
Conversation
Co-Authored-By: GPT-6 <noreply@openai.com>
This was referenced Oct 26, 2026
Owner
Author
Owner
Author
|
Closing in favor of kixelated/mp4-atom#254, now merged. It stores field-less runs as a count rather than refusing them, so the AV1, BBB, and ESDS fixtures keep decoding. (Written by Claude Opus 5.5) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A field-less
trunexpands its sample count into aVecwithout consuming per-sample bytes. The 4096-entry cap applies per run, so a roughly 16 KB moof with 1000 runs still materializes 4.1 million entries before media validation. This is the parser-side gap tracked by moq-dev/moq#6864.Approach
Refuse nonempty runs without per-sample fields on decode and encode, including first-sample-flags-only runs. Remove the arbitrary 4096 cap and allocate ordinary entries only as their fields are read. Empty runs remain supported.
Impact
Error::Unsupported.Alternatives
Replace
Trun.entries: Vec<TrunEntry>with a representation that stores repeated default entries as a count. That preserves field-less files but changes downstream APIs. Another count cap does not bound expansion across many runs.Validation
Both new refusal tests fail on the original parser. Local
just checkpassed, including all-feature compilation, Clippy with warnings denied, and formatting (cargo-shear reported existing unused-file warnings).CI passed 380 tests and failed the AV1, BBB, and ESDS fixture tests because they contain valid field-less runs. These assertions remain intact. The local all-feature test run was cancelled while waiting for the host load gate after CI supplied this decisive result.
Decisions needed
The fixture failures show that field-less runs are used by real supported inputs. Recommendation: replace the refusal proposal with a counted representation and migrate consumers together. This draft makes the narrower refusal option and its compatibility cost reviewable; do not merge it as-is or weaken the fixture tests to accept the regression. The MoQ resolver is independently useful, but fully bounding parsing still needs this representation change, a release, and adoption.
(Written by GPT-6)