Skip to content

chore(quest): finish m0/checks on the warm queue measurement - #720

Merged
kixelated merged 5 commits into
mainfrom
quest/m0/checks/README
Nov 12, 2026
Merged

kixelated merged 5 commits into
mainfrom
quest/m0/checks/README

Conversation

@kixelated

@kixelated kixelated commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Finishes quest/m0/checks on its gate measurement and adds the object cache miss as a gap quest.

Findings

Queue builds on nixos-rust2-ci (nspawn container rust2-ci on host nixos, not nixos2), CPU from the container journal's quest-gate scopes, matched to builds by end time:

Run Object cache CPU Wall
43265518031 0 hits / 55 misses 13m06s 5m11s
43290025781 0 hits / 55 misses (same crates) 19m00s 9m31s
43304642908 0/27, then 17 hits / 187 misses 8m51s 3m44s

Baseline: 65 CPU-minutes a run; cold queue builds on Nov 10 to 11 took 28 to 52. Local: fedora's quest-gate scopes totalled 122.2 CPU-hours on 2026-11-11 (baseline 100 to 130), but they cover every repo's agents, so rust2's share can't be separated.

Decisions

  • ✅ Finish the quest (rejected: rewrite it to local attribution). The gate goal is met at 9 to 19 CPU-minutes against 65, even with the cache missing. Local attribution needs quest-gate scopes tagged by repo, a change to the quest tool rather than rust2, and its children (diff selection, warm builds, optimized fixtures) all landed. Recorded as a choice for review.
  • Both former ## Waiting items resolved by /quest-unblock on 2026-11-12: a compiling queue build ran, and the CPU came from the nixos container's journal.

Validation

Re-read the mbx[cache] lines of runs 43290025781 and 43304642908 with gh run view --log; they match the table. CPU figures are from /quest-unblock's journal read, not re-run. quest check --base origin/main passes. No code changes.

Public API / wire: none.

Follow-ups

  • quest/m0/object-cache-miss.md - find why the object cache misses on an identical queue rebuild (store not persisting across jobs, or keys changing). Kept by the maintainer on 2026-11-12.

Models

Size: S
Implementer: Claude, claude-opus-5-5, unknown effort
Implementer: Claude Code, claude-opus-5-5, low effort (iterate, S)

🤖 Generated with Claude Code

Review

Rewritten by quest review after each round.

  • Head: 8d29ea6

  • Base: origin/main at 4fd6223

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1d205-0117-76d1-b702-3bc6262fbe49, round 2

  • Score: 10/10, The incremental documentation change clarifies the source and meaning of CPU measurements without introducing any actionable defects.

  • Findings: none

  • Reviewer: opencode, opencode-go/deepseek-v4.1-flash, high effort

  • Session: ses_e2dfaf8feffePII7W4GfhRMML1, round 2

  • Score: 10/10, The head fixes the provenance finding and the author's measured local-CPU evidence resolves the remaining tracking concern, so the documentation change is ready to land.

  • Findings: none

  • The last round's findings, at 6a8a3dc:

    • Refuted: medium, quest/m0/checks/README.md: Checks quest is closed without the local-check measurement it required; The response cites the fedora quest-gate scopes' measured CPU total (122.2 CPU-hours on 2026-11-11, within the 100-130 baseline) and explains that untagged scopes cannot be split per repository, so a rust2-local quest could not record that measurement; the journal contains those quest-gate Consumed-CPU entries and supports the claim.
    • Fixed: low, quest/m0/object-cache-miss.md:15: CPU-minutes are stated without provenance and may be wall time; quest/m0/object-cache-miss.md:15-17 now names the source as the quest-gate scopes' Consumed CPU in the rust2-ci container journal, with the journalctl path, and explicitly says it is not Actions wall time.

Head d305dc3 adds only the pick round's answer to the follow-up's Plan, which needs no new review.

Quest-Claim: c503136cfbc6b9a6
@pullfrog

pullfrog Bot commented Nov 12, 2026

Copy link
Copy Markdown

Pullfrog  | Review this ➔

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title Checks at moq's cost chore(quest): record the first warm queue build's cache stats Nov 12, 2026
…t cache miss

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title chore(quest): record the first warm queue build's cache stats chore(quest): finish m0/checks on the warm queue measurement Nov 12, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 12, 2026 23:21
@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 44 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f603f9a5-af3e-4185-83cd-5caf9b05c795
Commits

Reviewing files that changed from the base of the PR and between e809caa and d305dc3.

Files selected for processing: 2

  • quest/m0/checks/README.md
  • quest/m0/object-cache-miss.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated enabled auto-merge November 12, 2026 23:23

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes: docs-only quest bookkeeping across 2 files.

  • Finish m0/checks: removes quest/m0/checks/README.md now that the gate measurement is recorded in the PR.
  • Add m0/object-cache-miss: new gap quest with a goal, evidence from the three runs, and a plan to find the cause before fixing it. The figures match the PR table (17 hits of 204 lookups = 17 hits + 187 misses).

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit d2e1650 Nov 12, 2026
5 checks passed
@kixelated
kixelated deleted the quest/m0/checks/README branch November 12, 2026 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant