Skip to content

ci(queue): require the self-hosted build's own context - #715

Merged
kixelated merged 2 commits into
mainfrom
quest/m0/queue-context
Nov 12, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest/m0/queue-context

Conversation

@kixelated

@kixelated kixelated commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Finishes quest/m0/queue-context.md: the merge queue's required context comes from the self-hosted build itself, so a group no longer waits on GitHub-hosted runners after it builds (#709's group waited 1h45m+ for the ubuntu-latest Queue job).

Changes

  • queue.yml: the build call to queue-build.yml@main loses its if, so it runs on pull requests too. main's copy of queue-build.yml already skips its Build job on every event but merge_group, so a PR gets no runner, and the skipped job reports Queue build / Build.
  • The hosted Queue job is gone. A failed or cancelled build reports its own context failed or cancelled, which fails the group, so the relay job isn't needed.
  • The workflow_dispatch fallback now posts a skipped Queue build / Build check run instead of Queue.
  • queue-build.yml is unchanged (no overlap with ci(queue): build the merge queue warm through mbx #714's build-step edits).
  • Deletes the quest.

Evidence

  • On docs: trim agent instructions the shared quest rules already state #709's head, the PR-side run reported only Queue build (skipped) for the skipped call. That's why the quest's first recommendation (require Queue build / Build with the call still gated) would block every PR. When the call itself is skipped, GitHub names the context after the caller job alone.
  • Merge group run 43171064245 reported Queue build / Build from nixos-rust2-ci at 06:51 and the hosted Queue job at 08:51.
  • This PR's own pull_request run (43200937032) reports Queue build / Build: skipping: an ungated call whose inner job skips reports the skipped context the new requirement needs.
  • Unproven until it lands: that a merge group passes with only Queue build / Build required.

Decisions

  • Ruleset transition: ✅ switch main's required check from Queue to Queue build / Build (done 2026-11-12 by the coordinating session with the maintainer's approval), then queue this PR (rejected: requiring both contexts, keeping the hosted Queue job for a later PR). Other open PRs get the new context on their next push or from gh workflow run queue.yml -f sha=<head>.

Choices made without asking

  • Calling the build unconditionally instead of adding a self-hosted relay job. The rust2-queue group admits only queue-build.yml@main, so a relay in queue.yml can't run there.
  • A workflow_dispatch run now also calls the build, which skips on main's head. This is harmless.

Follow-ups

  • moq-dev/rind has the same Queue / Queue build workflow pair; its tree's /quest-plan should check for the same hosted relay job. moq-dev/moq has no queue workflow.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Review

Rewritten by quest review after each round.

  • Head: 801ce69

  • Base: origin/main at c15c9c3

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1d0a7-1ca7-7ec0-bc6e-df0f92f4b376, round 1

  • Score: 9/10, The change preserves PR-side skipping and merge-group failure reporting while removing the hosted-runner dependency, provided the repository ruleset is updated to require `Queue build / Build`; builds and tests were not run as instructed.

  • Findings: none

kixelated and others added 2 commits November 12, 2026 02:28
Quest-Claim: a6d8b893840d4c1d
The required Queue job ran on ubuntu-latest after the build, so a group
with a passed build waited on org-wide hosted capacity. Call the build on
pull requests too, where its job skips as Queue build / Build, and drop the
hosted job; the ruleset then requires the build's context.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title The merge queue's required check waits on no GitHub-hosted runner ci(queue): require the self-hosted build's own context Nov 12, 2026
@kixelated
kixelated marked this pull request as ready for review November 12, 2026 17:03
@kixelated
kixelated added this pull request to the merge queue Nov 12, 2026
@coderabbitai

coderabbitai Bot commented Nov 12, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The workflow now identifies Queue build / Build as the required check. The build call no longer has a merge-group-only condition, and the separate queue job is removed. The dispatch reporter creates a skipped check with the updated name while retaining full-commit-SHA validation. The document describing the proposed queue-context change and related follow-ups is deleted.

Merge Risk: Minimal · up to 801ce

The workflow now reports the Queue build / Build context directly, with no hosted relay job. No concrete merge-blocking problem was found. The first merge-group run after landing will confirm the behavior.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: the queue workflow now requires the self-hosted build's own check context (ci(queue) scope). It matches the raw summary, which describes the build call losing its cond…
Description check Passed The description ties directly to the changeset. It explains removing the hosted Queue job in queue.yml, ungating the queue-build.yml call, changing the workflow_dispatch fallback to post Queue build /…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: the queue workflow now requires the self-hosted build's own check context (ci(queue) scope). It matches the raw summary, which describes the build call losing its condition, the hosted Queue job being removed, and the dispatch reporter switching to Queue build / Build.

Full details: Description check

Explanation

The description ties directly to the changeset. It explains removing the hosted Queue job in queue.yml, ungating the queue-build.yml call, changing the workflow_dispatch fallback to post Queue build / Build, and deleting the quest document. It also gives evidence and ruleset follow-ups.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2f407728-0ccf-4e90-9d67-9fd5d77977aa
Commits

Reviewing files that changed from the base of the PR and between e7fb999 and 801ce69.

Files selected for processing: 2

  • .github/workflows/queue.yml
  • quest/m0/queue-context.md
Files with no reviewable changes: 1

  • quest/m0/queue-context.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Merged via the queue into main with commit b9ccf34 Nov 12, 2026
11 checks passed
@kixelated
kixelated deleted the quest/m0/queue-context branch November 12, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant