Repository navigation
ci(queue): require the self-hosted build's own context - #715
Conversation
Quest-Claim: a6d8b893840d4c1d
The required Queue job ran on ubuntu-latest after the build, so a group with a passed build waited on org-wide hosted capacity. Call the build on pull requests too, where its job skips as Queue build / Build, and drop the hosted job; the ruleset then requires the build's context. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. WalkthroughThe workflow now identifies Merge Risk:
|
Finishes
quest/m0/queue-context.md: the merge queue's required context comes from the self-hosted build itself, so a group no longer waits on GitHub-hosted runners after it builds (#709's group waited 1h45m+ for theubuntu-latestQueuejob).Changes
queue.yml: thebuildcall toqueue-build.yml@mainloses itsif, so it runs on pull requests too. main's copy ofqueue-build.ymlalready skips itsBuildjob on every event butmerge_group, so a PR gets no runner, and the skipped job reportsQueue build / Build.Queuejob is gone. A failed or cancelled build reports its own context failed or cancelled, which fails the group, so the relay job isn't needed.workflow_dispatchfallback now posts a skippedQueue build / Buildcheck run instead ofQueue.queue-build.ymlis unchanged (no overlap with ci(queue): build the merge queue warm through mbx #714's build-step edits).Evidence
Queue build(skipped) for the skipped call. That's why the quest's first recommendation (requireQueue build / Buildwith the call still gated) would block every PR. When the call itself is skipped, GitHub names the context after the caller job alone.Queue build / Buildfromnixos-rust2-ciat 06:51 and the hostedQueuejob at 08:51.pull_requestrun (43200937032) reportsQueue build / Build: skipping: an ungated call whose inner job skips reports the skipped context the new requirement needs.Queue build / Buildrequired.Decisions
main's required check fromQueuetoQueue build / Build(done 2026-11-12 by the coordinating session with the maintainer's approval), then queue this PR (rejected: requiring both contexts, keeping the hostedQueuejob for a later PR). Other open PRs get the new context on their next push or fromgh workflow run queue.yml -f sha=<head>.Choices made without asking
rust2-queuegroup admits onlyqueue-build.yml@main, so a relay inqueue.ymlcan't run there.workflow_dispatchrun now also calls the build, which skips on main's head. This is harmless.Follow-ups
Queue/Queue buildworkflow pair; its tree's/quest-planshould check for the same hosted relay job. moq-dev/moq has no queue workflow.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)
Review
Rewritten by
quest reviewafter each round.Head: 801ce69
Base: origin/main at c15c9c3
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1d0a7-1ca7-7ec0-bc6e-df0f92f4b376, round 1Score: 9/10,
The change preserves PR-side skipping and merge-group failure reporting while removing the hosted-runner dependency, provided the repository ruleset is updated to require `Queue build / Build`; builds and tests were not run as instructed.Findings: none