Skip to content

chore!: delete the UniFFI fork - #690

Merged
kixelated merged 3 commits into
mainfrom
quest/m0/delete-uniffi
Nov 10, 2026
Merged

kixelated merged 3 commits into
mainfrom
quest/m0/delete-uniffi

Conversation

@kixelated

@kixelated kixelated commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Deletes the UniFFI fork and everything that exists only for it, finishing quest/m0/delete-uniffi.md. Decided with the maintainer on 2026-11-09 in the quest audit: moq never builds on the fork, so its only consumers here were the binding benchmark's baseline and CI.

Changes

  • uniffi/ (1,426 files, ~118k lines), the root Cargo.toml and Cargo.lock (the workspace held only the fork), and just uniffi.
  • sh/dispatch.sh: the uniffi module and its root cargo fmt/clippy; sh/dispatch.test.py follows. just fix drops its root cargo fmt --all.
  • flake.nix: the uniffi, uniffi-bindgen* packages, the generator helper, the .#uniffi dev shell, and flock (only bench/ffi/run.sh used it).
  • nightly.yml: the uniffi-fixtures, uniffi-cpp (MSVC, Apple Clang), and uniffi-install jobs.
  • The binding benchmark's harness: bench/ffi/{run.sh,browser.sh,browser.ts,browser-page.ts,pins.toml,report.jq}, bench-ffi.yml, and just bench-ffi. bench/ffi/README.md keeps the BoltFFI comparison and the fork's generated sizes, retargeted at rust2-ffi's generators.
  • .taplo.toml's uniffi/** exclude.
  • Docs: the root README.md's fork bullet, .#uniffi command, and license note; AGENTS.md's first line; ffi/README.md's first paragraph.
  • Quests: quest mv quest/m2/uniffi-swift-arm.md quest/m2/swift-arm.md, its Goal rewritten around rust2-ffi's Swift skips on aarch64-linux (the paths in ffi/README.md, ffi/justfile, and ffi/tests/fixtures.rs follow). quest/m1/ffi-export/bench.md and quest/m0/nightly-green.md lose this quest from Required and are now unblocked. quest/README.md's m0 line and quest/m1/README.md's decision drop the link.

Cost before and after

From the 2026-11-09 nightly (run 42655190735) and Bench FFI runs on main:

before after
just gate (nightly Gate job), uniffi module check uniffi 3m38s + test uniffi 3m52s of a ~20 min run 0
just ci on a PR touching uniffi/ or a shared input the same ~7.5 min 0
nightly UniFFI fixtures 42 to 55 min, red since 2026-11-02 removed
nightly UniFFI C and C++ (MSVC, Apple Clang) 5 to 7 min each removed
nightly UniFFI install 9 to 10 min removed
Bench FFI (Linux, Swift) 61 to 124 min, and 40 to 42 min red removed

Not re-timed after: the remaining modules are unchanged, so the gate loses exactly the uniffi steps.

Public API

Breaking: the flake's uniffi, uniffi-bindgen, uniffi-bindgen-go, uniffi-bindgen-dart, and uniffi-bindgen-cpp packages and the .#uniffi dev shell are removed. No consumer pins them (moq decided on 2026-11-02 to skip the fork). No wire impact.

Choices made without asking

  • Kept the root rust-toolchain.toml (the flake's default shell and just bench read it) and rustfmt.toml (every project's cargo fmt finds it by walking up).
  • Named the moved quest quest/m2/swift-arm.md; its check after a nixpkgs bump is now that the default shell's nativeBuildInputs on aarch64-linux lists Swift, since .#uniffi is gone.
  • Did not edit quest/m0/checks/cache.md, whose Goal cites "root clippy" and "uniffi's test build" numbers that this makes stale: moq-dev/rust2#426 holds that quest and also edits uniffi/uniffi_macros and the fork's trybuild tests. Whichever lands second resolves the conflict by deleting those paths and re-measuring the warm gate without the fork.

For moq's tree

moq's quest/m3/ffi-exporter.md still describes the fork era: it links rust2 quests long deleted (quest/m1/uniffi.md, ffi-bytes.md, kt-ffi-calls.md, ffi-poll-protocol.md), plans moq-ffi on rust2-uniffi* crates, and cites uniffi/cpp/bindgen/.../obj.hpp. Its link to bench/ffi/README.md#boltffi-comparison still resolves. Its next audit should drop the fork-era requirements.

Follow-ups

None recommended: the benchmark's rebuild on rust2-ffi is already quest/m1/ffi-export/bench.md, and the remaining red nightly jobs are quest/m0/nightly-green.md.

Checks

just ci passed locally on the merge with main at 25bf348: it ran every module (lint, quest, driver, ffi, go, ts checks; sh, driver, ffi, go, ts tests), since flake.nix and justfile are shared inputs. Also passed: actionlint, shellcheck, shfmt, taplo format --check, nixfmt --check, sh/dispatch.test.py, quest check --base origin/main, just --list, and evaluating the flake's packages and default dev shell.

Merged origin/main for a justfile conflict: main deleted bench-nix and this PR deleted bench-ffi and just fix's cargo fmt --all; the merge drops all three.

Models

Size: M
Implementer: Claude Code, claude-opus-5-5, medium effort
Implementer: Claude Code, claude-opus-5-5, medium effort (iterate, M)

🤖 Generated with Claude Code

(Written by Opus 5.5 with medium effort)

Review

Rewritten by quest review after each round.

  • Reviewer: Codex, gpt-6.1-sol, medium effort
  • Session: 01a1c45b-7bec-72e0-8a3d-4e0875760c36, round 1
  • Head: 25bf348
  • Base: origin/main at d16670c
  • Score: 9/10, The deletion consistently removes the UniFFI workspace, tooling, CI jobs, and benchmark harness without disrupting the remaining independent workspaces; code inspection found no actionable defects, though builds and tests were not run as instructed.
  • Findings: none

Quest-Claim: f971856dfc57254d
@pullfrog

pullfrog Bot commented Nov 10, 2026

Copy link
Copy Markdown

Pullfrog  | Review this ➔

moq decided never to build on it, so its only consumers here were the
binding benchmark's baseline and nightly jobs. Removes uniffi/, the root
Cargo workspace, the flake's uniffi* packages and .#uniffi shell, the
nightly uniffi-* jobs, and the binding benchmark's harness and workflow.
The benchmark's README keeps the BoltFFI comparison and the fork's sizes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title Delete the UniFFI fork chore!: delete the UniFFI fork Nov 10, 2026
@kixelated
kixelated marked this pull request as ready for review November 10, 2026 07:29
@kixelated
kixelated added this pull request to the merge queue Nov 10, 2026
Merged via the queue into main with commit 784d5e0 Nov 10, 2026
6 checks passed
@kixelated
kixelated deleted the quest/m0/delete-uniffi branch November 10, 2026 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant