Repository navigation
ci: check in the merge queue and drop the quest land gate - #249
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 56 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 9be8ff17303a07cf9847622281968c3bb93cefa7.
No actionable bugs found. Replacing the unused custom Land gate with the native merge queue is a reasonable simplification: just ci retains check-then-test failure propagation, manual runs remain hosted, and merge-group runs have a hosted fallback before the runner variable is configured. Removing the Land-specific guard test matches removal of its workflow; the remaining repository changes are URL migration and corresponding documentation.
The documented rollout prerequisites matter: skipped PR checks are not themselves evidence that the combined tree passed. The required Check plus native queue ruleset and the self-hosted runner's provisioning/isolation still need operational verification. Consider a small event-matrix regression for PR skip, queue/manual execution, and destroyed-event cancellation.
Verification limits: static diff and surrounding workflow/Nix/justfile review, with an independent read-only pass. I did not run checks/tests or verify GitHub rulesets, runner settings, cancellation behavior, or the reported local CI result.
(Written by OpenAI)
Problem
Hosted CI is starved by another repository's backlog, and the
quest landgate (#137) never got its App, environment, and ruleset setup. Now that rust2 lives in moq-dev, it can use GitHub's native merge queue and this host's self-hosted runners the way moq-dev/moq does.Approach
Copies moq's model:
just cirunsjust checkthenjust test. Check's job calls it, and CONTRIBUTING, AGENTS.md, and README name it as the local check before every push.pull_requestandmerge_group(checks_requested,destroyed). Main PRs report Check as skipped, and the queue runs it onvars.RUST2_QUEUE_RUNNER || 'ubuntu-24.04-arm'. The Nix installer is skipped on a self-hosted runner. Adestroyedrun only cancels its group's in-flight build through the concurrency group..github/actionlint.yamlignoresdestroyedexactly as moq does (Actionlint errors formerge_groupevent activity typedestroyedrhysd/actionlint#726).land.yml,land.test.tsand itsjust testline, CONTRIBUTING's landing rule and interimgh pr mergeline, andquest/m1/land.mdwith its link. CONTRIBUTING gets a Merge queue section.quest merge <pr> <token> --land <sha>enables auto-merge bound to the reviewed head, which enters the base's merge queue when it has one (quest merge --help), so/quest-mergekeeps working unchanged.kixelated/rust2becomesmoq-dev/rust2across Cargo.tomlrepositoryfields, READMEs, quests,driver/src/rustc.rs, and bench scripts. Inquest/m3/quest-workflow-guard.md, the link to the deletedland.test.tsis now a permalink atf78c588f. That quest is kixelated/quest's own gap, so it stays.Choices made here:
closedoreditedpull_request types. In moq they only servereleasePRs, which run Check. No rust2 PR runs Check, so a close has nothing to cancel.workflow_dispatchstays so Check can run by hand on a branch. It runs on the hosted runner.Impact
repositoryURLs change to moq-dev/rust2.Alternatives
quest land: dropped. It needs an App bypass and an environment secret, and the native queue gives the same combined-tree check.gh pr mergeas moq's CONTRIBUTING does:quest merge --landalready enters the native queue and binds the reviewed SHA, so the quest skills don't change.Maintainer steps
mainthat requires theCheckstatus check, enables the merge queue with squash merges, and blocks deletion and force pushes. Keep the admin bypass for emergencies. Retire any earliermainruleset that requiresquest landor names the land App as a bypass actor.quest-land(org-wide, ephemeral, registered through the moq-bot App).RUST2_QUEUE_RUNNER=quest-land, then check that the next queue run lands onnixos-quest-landand passes.landenvironment (LAND_APP_CLIENT_ID,LAND_APP_PRIVATE_KEY), and uninstall or delete the land GitHub App if nothing else uses it.Follow-ups
None.
Review
quest review --base origin/main, round 1)Local checks:
nix develop --command just cipassed on 9be8ff1.(written by Claude Opus 5.5)
🤖 Generated with Claude Code